Subject: Re: [PATCH v6 2/2] net: phy: add Maxlinear GPY115/21x/24x driver

From: Andrew Lunn <[email-masked]>
Date: Tue, 20 Jul 2021 15:02:23 +0200

On Tue, Jul 20, 2021 at 03:35:17AM +0000, Liang Xu wrote:
> On 20/7/2021 4:48 am, Andrew Lunn wrote:
> > This email was sent from outside of MaxLinear.
> >
> >
> >> +/* PHY ID */
> >> +#define PHY_ID_GPYx15B_MASK  0xFFFFFFFC
> >> +#define PHY_ID_GPY21xB_MASK  0xFFFFFFF9
> > That is an odd mask. Is that really correct?
> >
> >       Andrew
> >
> Hi Andrew,
> 
> 
> Yes, this is correct and has been tested.
> 
> It's special because of a PHY ID scheme change during manufacturing.

O.K. It is just a really odd mask. And putting the revision in the
middle, not at the end? And none of the IDs have bit 0 set. It just
all adds up to it looking wrong. So i had to ask.

    Andrew