Subject: Re: [PATCH V2 net-next 5/7] net: fec: add MAC internal delayed clock feature support

From: Andrew Lunn <[email-masked]>
Date: Wed, 28 Jul 2021 16:10:47 +0200

> +	/* For rgmii internal delay, valid values are 0ps and 2000ps */
> +	if (of_property_read_u32(np, "tx-internal-delay-ps", &rgmii_delay))
> +		fep->rgmii_txc_dly = true;
> +	if (of_property_read_u32(np, "rx-internal-delay-ps", &rgmii_delay))
> +		fep->rgmii_rxc_dly = true;

I don't see any validation of the only supported values are 0ps and
2000ps.

	Andrew