Subject: Re: [PATCH 04/13] HV: Mark vmbus ring buffer visible to host in Isolation VM

From: Joerg Roedel <[email-masked]>
Date: Mon, 2 Aug 2021 14:07:59 +0200

On Wed, Jul 28, 2021 at 10:52:19AM -0400, Tianyu Lan wrote:
> +	if (type == HV_GPADL_BUFFER)
> +		index = 0;
> +	else
> +		index = channel->gpadl_range[1].gpadlhandle ? 2 : 1;

Hmm... This doesn't look very robust. Can you set fixed indexes for
different buffer types? HV_GPADL_BUFFER already has fixed index 0. But
as it is implemented here you risk that index 2 gets overwritten by
subsequent calls.