From: Andrew Lunn <andrew@lunn•ch>
To: Saravana Kannan <saravanak@google•com>
Cc: "Alvin Šipraga" <ALSI@bang-olufsen•dk>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Vladimir Oltean" <vladimir.oltean@nxp•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"Jakub Kicinski" <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Frank Rowand" <frowand.list@gmail•com>,
"Rob Herring" <robh+dt@kernel•org>
Subject: Re: [PATCH net] net: dsa: sja1105: fix use-after-free after calling of_find_compatible_node, or worse
Date: Mon, 23 Aug 2021 22:43:58 +0200 [thread overview]
Message-ID: <YSQIjtkJPg3lFg7t@lunn.ch> (raw)
In-Reply-To: <CAGETcx-7xgt5y_zNHzSMQf4YFCmWRPfP4_voshbNxKPgQ=b1tA@mail.gmail.com>
> I thought about this in the background the past few days. I think
> there are a couple of options:
> 1. We (community/Andrew) agree that this driver would only work with
> fw_devlink=on and we can confirm that the other upstream uses of
> "realtek,rtl8366rb" won't have any unprobed consumers problem and
> switch to using my patch. Benefit is that it's a trivial and quick
> change that gets things working again.
I don't think realtek,rtl8366rb is doing anything particularly
unusual. It is not the only switch driver with an MDIO bus driver with
its internal PHYs on it.
> 2. The "realtek,rtl8366rb" driver needs to be fixed to use a
> "component device".
Again, i don't think "realtek,rtl8366rb is doing anything unusual,
compared to the other DSA drivers. If you are suggesting it needs to
make use of the component driver, you might also be suggesting that
all the switch drivers need to be component devices. I don't fully
understand the details here, but it might be, you are also suggesting
some Ethernet drivers need modifying to use the component framework?
And that is not going to fly.
This has all worked until now, things might need a few iterations with
deferral, but we get there in the end. Maybe we need to back out the
phy-handle patch? It does appear to be causing regressions.
Andrew
next prev parent reply other threads:[~2021-08-23 20:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 14:52 [PATCH net] net: dsa: sja1105: fix use-after-free after calling of_find_compatible_node, or worse Vladimir Oltean
2021-08-17 21:25 ` Alvin Šipraga
2021-08-17 22:05 ` Andrew Lunn
2021-08-17 22:19 ` Alvin Šipraga
2021-08-17 22:31 ` Vladimir Oltean
2021-08-17 22:40 ` Vladimir Oltean
2021-08-17 23:01 ` Alvin Šipraga
2021-08-18 2:46 ` Saravana Kannan
2021-08-18 10:18 ` Alvin Šipraga
2021-08-19 3:28 ` Saravana Kannan
2021-08-19 11:22 ` Vladimir Oltean
2021-08-19 13:46 ` Alvin Šipraga
2021-08-20 0:50 ` Saravana Kannan
2021-08-19 13:35 ` Andrew Lunn
2021-08-19 23:52 ` Saravana Kannan
2021-08-20 0:37 ` Vladimir Oltean
2021-08-20 1:25 ` Saravana Kannan
2021-08-20 13:01 ` Andrew Lunn
2021-08-19 13:42 ` Alvin Šipraga
2021-08-20 1:08 ` Saravana Kannan
2021-08-20 16:52 ` Saravana Kannan
2021-08-20 17:54 ` Andrew Lunn
2021-08-20 18:10 ` Saravana Kannan
2021-08-22 14:19 ` Alvin Šipraga
2021-08-23 18:50 ` Saravana Kannan
2021-08-23 20:43 ` Andrew Lunn [this message]
2021-08-23 21:23 ` Saravana Kannan
2021-08-25 13:40 ` Alvin Šipraga
2021-08-26 5:33 ` Saravana Kannan
2021-08-26 7:49 ` Saravana Kannan
2021-08-26 11:09 ` Alvin Šipraga
2021-08-18 9:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSQIjtkJPg3lFg7t@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=ALSI@bang-olufsen$(echo .)dk \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=saravanak@google$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox