From: Leon Romanovsky <leon@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: "David S . Miller" <davem@davemloft•net>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>, Ariel Elior <aelior@marvell•com>,
Bin Luo <luobin9@huawei•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Coiby Xu <coiby.xu@gmail•com>,
Derek Chickles <dchickles@marvell•com>,
drivers@pensando•io, Eric Dumazet <eric.dumazet@gmail•com>,
Felix Manlunas <fmanlunas@marvell•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Geetha sowjanya <gakula@marvell•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
GR-everest-linux-l2@marvell•com, GR-Linux-NIC-Dev@marvell•com,
hariprasad <hkelam@marvell•com>, Ido Schimmel <idosch@nvidia•com>,
intel-wired-lan@lists•osuosl.org,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Jerin Jacob <jerinj@marvell•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Jiri Pirko <jiri@nvidia•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Linu Cherian <lcherian@marvell•com>,
linux-kernel@vger•kernel.org, linux-omap@vger•kernel.org,
linux-rdma@vger•kernel.org, linux-staging@lists•linux.dev,
Manish Chopra <manishc@marvell•com>,
Michael Chan <michael.chan@broadcom•com>,
Moshe Shemesh <moshe@nvidia•com>,
netdev@vger•kernel.org, oss-drivers@corigine•com,
Richard Cochran <richardcochran@gmail•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Salil Mehta <salil.mehta@huawei•com>,
Satanand Burla <sburla@marvell•com>,
Shannon Nelson <snelson@pensando•io>,
Shay Drory <shayd@nvidia•com>,
Simon Horman <simon.horman@corigine•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Sunil Goutham <sgoutham@marvell•com>,
Taras Chornyi <tchornyi@marvell•com>,
Tariq Toukan <tariqt@nvidia•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
UNGLinuxDriver@microchip•com, Vadym Kochan <vkochan@marvell•com>,
Vivien Didelot <vivien.didelot@gmail•com>,
Vladimir Oltean <vladimir.oltean@nxp•com>,
Yisen Zhuang <yisen.zhuang@huawei•com>
Subject: Re: [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device
Date: Wed, 29 Sep 2021 17:16:28 +0300 [thread overview]
Message-ID: <YVR1PKQjsBfvUTPU@unreal> (raw)
In-Reply-To: <20210929065549.43b13203@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, Sep 29, 2021 at 06:55:49AM -0700, Jakub Kicinski wrote:
> On Wed, 29 Sep 2021 15:00:45 +0300 Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia•com>
> >
> > Mulitport slave device doesn't support devlink reload, so instead of
> > complicating initialization flow with devlink_reload_enable() which
> > will be removed in next patch, set specialized devlink ops callbacks
> > for reload operations.
> >
> > This fixes an error when reload counters exposed (and equal zero) for
> > the mode that is not supported at all.
> >
> > Fixes: d89ddaae1766 ("net/mlx5: Disable devlink reload for multi port slave device")
> > Signed-off-by: Leon Romanovsky <leonro@nvidia•com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 13 ++++++++++---
> > 1 file changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> > index 47c9f7f5bb79..e85eca6976a9 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> > @@ -309,14 +309,17 @@ static struct devlink_ops mlx5_devlink_ops = {
> > #endif
> > .flash_update = mlx5_devlink_flash_update,
> > .info_get = mlx5_devlink_info_get,
> > + .trap_init = mlx5_devlink_trap_init,
> > + .trap_fini = mlx5_devlink_trap_fini,
> > + .trap_action_set = mlx5_devlink_trap_action_set,
> > +};
> > +
> > +static struct devlink_ops mlx5_devlink_reload = {
> > .reload_actions = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
> > BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
> > .reload_limits = BIT(DEVLINK_RELOAD_LIMIT_NO_RESET),
> > .reload_down = mlx5_devlink_reload_down,
> > .reload_up = mlx5_devlink_reload_up,
> > - .trap_init = mlx5_devlink_trap_init,
> > - .trap_fini = mlx5_devlink_trap_fini,
> > - .trap_action_set = mlx5_devlink_trap_action_set,
> > };
> >
> > void mlx5_devlink_trap_report(struct mlx5_core_dev *dev, int trap_id, struct sk_buff *skb,
> > @@ -791,6 +794,7 @@ static void mlx5_devlink_traps_unregister(struct devlink *devlink)
> >
> > int mlx5_devlink_register(struct devlink *devlink)
> > {
> > + struct mlx5_core_dev *dev = devlink_priv(devlink);
> > int err;
> >
> > err = devlink_params_register(devlink, mlx5_devlink_params,
> > @@ -808,6 +812,9 @@ int mlx5_devlink_register(struct devlink *devlink)
> > if (err)
> > goto traps_reg_err;
> >
> > + if (!mlx5_core_is_mp_slave(dev))
> > + devlink_set_ops(devlink, &mlx5_devlink_reload);
>
> Does this work? Where do you make a copy of the ops? 🤔 You can't modify
> the driver-global ops, to state the obvious.
devlink_ops pointer is not constant at this stage, so why can't I copy
reload_* pointers to the "main" devlink ops?
I wanted to avoid to copy all pointers.
Thanks
next prev parent reply other threads:[~2021-09-29 14:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 12:00 [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 1/5] devlink: Add missed notifications iterators Leon Romanovsky
2021-09-29 13:29 ` Vladimir Oltean
2021-09-29 12:00 ` [PATCH net-next v1 2/5] devlink: Allow modification of devlink ops Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 3/5] devlink: Allow set specific ops callbacks dynamically Leon Romanovsky
2021-09-29 12:25 ` Greg Kroah-Hartman
2021-09-29 12:58 ` Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 4/5] net/mlx5: Register separate reload devlink ops for multiport device Leon Romanovsky
2021-09-29 13:55 ` Jakub Kicinski
2021-09-29 14:16 ` Leon Romanovsky [this message]
2021-09-29 14:26 ` Jakub Kicinski
2021-09-29 14:31 ` Leon Romanovsky
2021-09-29 14:35 ` Jakub Kicinski
2021-09-29 15:24 ` Leon Romanovsky
2021-09-29 12:00 ` [PATCH net-next v1 5/5] devlink: Delete reload enable/disable interface Leon Romanovsky
2021-09-29 13:40 ` [PATCH net-next v1 0/5] Devlink reload and missed notifications fix Jakub Kicinski
2021-09-29 13:46 ` Vladimir Oltean
2021-09-29 13:56 ` Jakub Kicinski
2021-09-29 14:20 ` Leon Romanovsky
2021-09-29 14:13 ` Leon Romanovsky
2021-09-29 14:39 ` Jakub Kicinski
2021-09-29 15:31 ` Leon Romanovsky
2021-09-29 17:55 ` Jakub Kicinski
2021-09-29 19:11 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVR1PKQjsBfvUTPU@unreal \
--to=leon@kernel$(echo .)org \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=coiby.xu@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dchickles@marvell$(echo .)com \
--cc=drivers@pensando$(echo .)io \
--cc=eric.dumazet@gmail$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fmanlunas@marvell$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lcherian@marvell$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=luobin9@huawei$(echo .)com \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=moshe@nvidia$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=salil.mehta@huawei$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=shayd@nvidia$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=tariqt@nvidia$(echo .)com \
--cc=tchornyi@marvell$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vkochan@marvell$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=yisen.zhuang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox