From: Leon Romanovsky <leon@kernel•org>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: "David S . Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
Andrew Lunn <andrew@lunn•ch>, Ariel Elior <aelior@marvell•com>,
Bin Luo <luobin9@huawei•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Coiby Xu <coiby.xu@gmail•com>,
Derek Chickles <dchickles@marvell•com>,
"drivers@pensando•io" <drivers@pensando•io>,
Felix Manlunas <fmanlunas@marvell•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Geetha sowjanya <gakula@marvell•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
"GR-everest-linux-l2@marvell•com"
<GR-everest-linux-l2@marvell•com>,
"GR-Linux-NIC-Dev@marvell•com" <GR-Linux-NIC-Dev@marvell•com>,
hariprasad <hkelam@marvell•com>, Ido Schimmel <idosch@nvidia•com>,
Intel Corporation <linuxwwan@intel•com>,
"intel-wired-lan@lists•osuosl.org"
<intel-wired-lan@lists•osuosl.org>,
Ioana Ciornei <ioana.ciornei@nxp•com>,
Jerin Jacob <jerinj@marvell•com>,
Jesse Brandeburg <jesse.brandeburg@intel•com>,
Jiri Pirko <jiri@nvidia•com>,
Jonathan Lemon <jonathan.lemon@gmail•com>,
Linu Cherian <lcherian@marvell•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-omap@vger•kernel.org" <linux-omap@vger•kernel.org>,
"linux-rdma@vger•kernel.org" <linux-rdma@vger•kernel.org>,
"linux-staging@lists•linux.dev" <linux-staging@lists•linux.dev>,
Loic Poulain <loic.poulain@linaro•org>,
Manish Chopra <manishc@marvell•com>,
M Chetan Kumar <m.chetan.kumar@intel•com>,
Michael Chan <michael.chan@broadcom•com>,
Michael Guralnik <michaelgur@mellanox•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"oss-drivers@corigine•com" <oss-drivers@corigine•com>,
Richard Cochran <richardcochran@gmail•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Satanand Burla <sburla@marvell•com>,
Sergey Ryazanov <ryazanov.s.a@gmail•com>,
Shannon Nelson <snelson@pensando•io>,
Simon Horman <simon.horman@corigine•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Sunil Goutham <sgoutham@marvell•com>,
Taras Chornyi <tchornyi@marvell•com>,
Tariq Toukan <tariqt@nvidia•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
"UNGLinuxDriver@microchip•com" <UNGLinuxDriver@microchip•com>,
Vadym Kochan <vkochan@marvell•com>,
Vivien Didelot <vivien.didelot@gmail•com>
Subject: Re: [PATCH net-next v1 21/21] net: dsa: Move devlink registration to be last devlink command
Date: Wed, 29 Sep 2021 16:07:49 +0300 [thread overview]
Message-ID: <YVRlJagqFInXCgGZ@unreal> (raw)
In-Reply-To: <20210929130226.j53fcztm6utpt3tu@skbuf>
On Wed, Sep 29, 2021 at 01:02:27PM +0000, Vladimir Oltean wrote:
> Hi Leon,
>
> On Sat, Sep 25, 2021 at 02:23:01PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@nvidia•com>
> >
> > This change prevents from users to access device before devlink
> > is fully configured.
> >
> > Signed-off-by: Leon Romanovsky <leonro@nvidia•com>
> > ---
> > net/dsa/dsa2.c | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
> > index a020339e1973..8ca6a1170c9d 100644
> > --- a/net/dsa/dsa2.c
> > +++ b/net/dsa/dsa2.c
> > @@ -848,7 +848,6 @@ static int dsa_switch_setup(struct dsa_switch *ds)
> > dl_priv = devlink_priv(ds->devlink);
> > dl_priv->ds = ds;
> >
> > - devlink_register(ds->devlink);
> > /* Setup devlink port instances now, so that the switch
> > * setup() can register regions etc, against the ports
> > */
> > @@ -874,8 +873,6 @@ static int dsa_switch_setup(struct dsa_switch *ds)
> > if (err)
> > goto teardown;
> >
> > - devlink_params_publish(ds->devlink);
> > -
> > if (!ds->slave_mii_bus && ds->ops->phy_read) {
> > ds->slave_mii_bus = mdiobus_alloc();
> > if (!ds->slave_mii_bus) {
> > @@ -891,7 +888,7 @@ static int dsa_switch_setup(struct dsa_switch *ds)
> > }
> >
> > ds->setup = true;
> > -
> > + devlink_register(ds->devlink);
> > return 0;
> >
> > free_slave_mii_bus:
> > @@ -906,7 +903,6 @@ static int dsa_switch_setup(struct dsa_switch *ds)
> > list_for_each_entry(dp, &ds->dst->ports, list)
> > if (dp->ds == ds)
> > dsa_port_devlink_teardown(dp);
> > - devlink_unregister(ds->devlink);
> > devlink_free(ds->devlink);
> > ds->devlink = NULL;
> > return err;
> > @@ -919,6 +915,9 @@ static void dsa_switch_teardown(struct dsa_switch *ds)
> > if (!ds->setup)
> > return;
> >
> > + if (ds->devlink)
> > + devlink_unregister(ds->devlink);
> > +
> > if (ds->slave_mii_bus && ds->ops->phy_read) {
> > mdiobus_unregister(ds->slave_mii_bus);
> > mdiobus_free(ds->slave_mii_bus);
> > @@ -934,7 +933,6 @@ static void dsa_switch_teardown(struct dsa_switch *ds)
> > list_for_each_entry(dp, &ds->dst->ports, list)
> > if (dp->ds == ds)
> > dsa_port_devlink_teardown(dp);
> > - devlink_unregister(ds->devlink);
> > devlink_free(ds->devlink);
> > ds->devlink = NULL;
> > }
> > --
> > 2.31.1
> >
>
> Sorry, I did not have time to review/test this change earlier.
> I now see this WARN_ON being triggered when I boot a board:
Sorry about that, it was missed in one of my rebases.
The fix was posted here.
https://lore.kernel.org/all/2ed1159291f2a589b013914f2b60d8172fc525c1.1632916329.git.leonro@nvidia.com
Thanks
prev parent reply other threads:[~2021-09-29 13:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-25 11:22 [PATCH net-next v1 00/21] Move devlink_register to be last devlink command Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 01/21] devlink: Notify users when objects are accessible Leon Romanovsky
2021-09-28 2:49 ` Eric Dumazet
2021-09-28 7:34 ` Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 02/21] bnxt_en: Register devlink instance at the end devlink configuration Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 03/21] liquidio: Overcome missing device lock protection in init/remove flows Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 04/21] dpaa2-eth: Register devlink instance at the end of probe Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 05/21] net: hinic: Open device for the user access when it is ready Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 06/21] ice: Open devlink when device " Leon Romanovsky
2021-09-27 19:47 ` Jesse Brandeburg
2021-09-25 11:22 ` [PATCH net-next v1 07/21] octeontx2: Move devlink registration to be last devlink command Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 08/21] net/prestera: Split devlink and traps registrations to separate routines Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 09/21] net/mlx4: Move devlink_register to be the last initialization command Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 10/21] net/mlx5: Accept devlink user input after driver initialization complete Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 11/21] mlxsw: core: Register devlink instance last Leon Romanovsky
2021-09-26 14:56 ` Ido Schimmel
2021-09-25 11:22 ` [PATCH net-next v1 12/21] net: mscc: ocelot: delay devlink registration to the end Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 13/21] nfp: Move delink_register to be last command Leon Romanovsky
2021-09-27 8:39 ` Simon Horman
2021-09-27 11:53 ` Leon Romanovsky
2021-09-27 12:20 ` Simon Horman
2021-09-25 11:22 ` [PATCH net-next v1 14/21] ionic: Move devlink registration to be last devlink command Leon Romanovsky
2021-09-27 16:07 ` Shannon Nelson
2021-09-25 11:22 ` [PATCH net-next v1 15/21] qed: " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 16/21] net: ethernet: ti: " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 17/21] netdevsim: " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 18/21] net: wwan: iosm: Move devlink_register " Leon Romanovsky
2021-09-25 11:22 ` [PATCH net-next v1 19/21] ptp: ocp: Move devlink registration " Leon Romanovsky
2021-09-25 11:23 ` [PATCH net-next v1 20/21] staging: qlge: " Leon Romanovsky
2021-09-25 11:23 ` [PATCH net-next v1 21/21] net: dsa: " Leon Romanovsky
2021-09-29 13:02 ` Vladimir Oltean
2021-09-29 13:07 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVRlJagqFInXCgGZ@unreal \
--to=leon@kernel$(echo .)org \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=coiby.xu@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dchickles@marvell$(echo .)com \
--cc=drivers@pensando$(echo .)io \
--cc=f.fainelli@gmail$(echo .)com \
--cc=fmanlunas@marvell$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hkelam@marvell$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=ioana.ciornei@nxp$(echo .)com \
--cc=jerinj@marvell$(echo .)com \
--cc=jesse.brandeburg@intel$(echo .)com \
--cc=jiri@nvidia$(echo .)com \
--cc=jonathan.lemon@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lcherian@marvell$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linuxwwan@intel$(echo .)com \
--cc=loic.poulain@linaro$(echo .)org \
--cc=luobin9@huawei$(echo .)com \
--cc=m.chetan.kumar@intel$(echo .)com \
--cc=manishc@marvell$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=michaelgur@mellanox$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=ryazanov.s.a@gmail$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sburla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=snelson@pensando$(echo .)io \
--cc=tariqt@nvidia$(echo .)com \
--cc=tchornyi@marvell$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vkochan@marvell$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox