Subject: Re: [PATCH v3 8/8] dt-bindings: adin1100: Add binding for ADIN1100 Ethernet PHY

From: Rob Herring <[email-masked]>
Date: Mon, 11 Oct 2021 19:47:17 -0500

On Mon, Oct 11, 2021 at 05:22:15PM +0300, [email-masked] wrote:
> From: Alexandru Tachici <[email-masked]>
> 
> DT bindings for the ADIN1100 10BASE-T1L Ethernet PHY.
> 
> Signed-off-by: Alexandru Tachici <[email-masked]>
> ---
>  .../devicetree/bindings/net/adi,adin1100.yaml | 30 +++++++++++++++++++
>  1 file changed, 30 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/adi,adin1100.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/adi,adin1100.yaml b/Documentation/devicetree/bindings/net/adi,adin1100.yaml
> new file mode 100644
> index 000000000000..7f98ea8fdf51
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/adi,adin1100.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/adi,adin1100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Analog Devices ADIN1100 PHY
> +
> +maintainers:
> +  - Alexandru Tachici <[email-masked]>
> +
> +description:
> +  Bindings for Analog Devices Industrial Low Power 10BASE-T1L Ethernet PHY

This schema doesn't do anything. ethernet-phy.yaml is already applied 
based on the node name and you haven't added any phy specific 
properties.

> +
> +allOf:
> +  - $ref: ethernet-phy.yaml#
> +
> +examples:
> +  - |
> +    ethernet {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        10base-t1l-2.4vpp = <0>;
> +
> +        ethernet-phy@0 {
> +            compatible = "ethernet-phy-id0283.bc81";
> +            reg = <0>;
> +        };
> +    };
> -- 
> 2.25.1
> 
>