Subject: Re: [PATCH 2/2] net: ethernet: Add driver for Sunplus SP7021

From: Andrew Lunn <[email-masked]>
Date: Wed, 3 Nov 2021 20:30:49 +0100

> config NET_VENDOR_SUNPLUS
> 	bool "Sunplus devices"
> 	default y
> 	depends on ARCH_SUNPLUS

Does it actually depend on ARCH_SUNPLUS? What do you make use of?

Ideally, you want it to also build with COMPILE_TEST, so that the
driver gets build by 0-day and all the other build bots.

> 	---help---
> 	  If you have a network (Ethernet) card belonging to this
> 	  class, say Y here.
> 
> 	  Note that the answer to this question doesn't directly
> 	  affect the kernel: saying N will just cause the configurator
> 	  to skip all the questions about Sunplus cards. If you say Y,
> 	  you will be asked for your specific card in the following
> 	  questions.
> 
> if NET_VENDOR_SUNPLUS
> 
> config SP7021_EMAC
> 	tristate "Sunplus Dual 10M/100M Ethernet (with L2 switch) devices"
> 	depends on ETHERNET && SOC_SP7021

Does it actually depend on SOC_SP7021 to build?

     Andrew