From: Andrew Lunn <andrew@lunn•ch>
To: bage@linutronix•de
Cc: Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
davem@davemloft•net, netdev@vger•kernel.org,
Benedikt Spranger <b.spranger@linutronix•de>
Subject: Re: [PATCH] phy: phy_ethtool_ksettings_set: Don't discard phy_start_aneg's return
Date: Fri, 5 Nov 2021 19:32:51 +0100 [thread overview]
Message-ID: <YYV40/2N+2j02V/f@lunn.ch> (raw)
In-Reply-To: <20211105153648.8337-1-bage@linutronix.de>
On Fri, Nov 05, 2021 at 04:36:48PM +0100, bage@linutronix•de wrote:
> From: Bastian Germann <bage@linutronix•de>
>
> Take the return of phy_start_aneg into account so that ethtool will handle
> negotiation errors and not silently accept invalid input.
Hi Bastian
What PHY driver are you using this with? phy_start_aneg() generally
does not return errors, except for -EIO/-TIMEDOUT because
communication with the PHY has failed. All parameter validation should
of already happened before the call to phy_start_aneg(). So i'm
wondering if the PHY driver is doing something wrong.
The change itself however does seems sensible. If the PHY has
disappeared, returning -EIO would be valid.
Andrew
next prev parent reply other threads:[~2021-11-05 18:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 15:36 [PATCH] phy: phy_ethtool_ksettings_set: Don't discard phy_start_aneg's return bage
2021-11-05 18:32 ` Andrew Lunn [this message]
2021-11-08 14:21 ` Bastian Germann
2021-11-06 21:52 ` Heiner Kallweit
2021-11-08 14:25 ` Bastian Germann
2021-11-10 8:14 ` Heiner Kallweit
2021-11-08 14:18 ` [PATCH net v2] net: " bage
2021-11-08 14:25 ` Russell King (Oracle)
2021-11-08 15:06 ` Benedikt Spranger
2021-11-08 15:40 ` Russell King (Oracle)
2021-11-08 16:09 ` Andrew Lunn
2021-11-08 16:32 ` Bastian Germann
2021-11-08 17:57 ` Andrew Lunn
2021-11-08 18:01 ` Heiner Kallweit
2021-11-08 18:06 ` Russell King (Oracle)
2021-11-08 19:02 ` Benedikt Spranger
2021-11-08 19:35 ` Heiner Kallweit
2021-11-09 18:29 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYV40/2N+2j02V/f@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=b.spranger@linutronix$(echo .)de \
--cc=bage@linutronix$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox