From: Andrew Lunn <andrew@lunn•ch>
To: Manish Chopra <manishc@marvell•com>
Cc: Ariel Elior <aelior@marvell•com>,
Jakub Kicinski <kuba@kernel•org>,
Greg KH <gregkh@linuxfoundation•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"stable@vger•kernel.org" <stable@vger•kernel.org>,
Sudarsana Reddy Kalluru <skalluru@marvell•com>,
"malin1024@gmail•com" <malin1024@gmail•com>,
Shai Malin <smalin@marvell•com>,
Omkar Kulkarni <okulkarni@marvell•com>,
Nilesh Javali <njavali@marvell•com>,
"GR-everest-linux-l2@marvell•com"
<GR-everest-linux-l2@marvell•com>
Subject: Re: [EXT] Re: [PATCH net-next 1/2] bnx2x: Utilize firmware 7.13.20.0
Date: Mon, 8 Nov 2021 14:44:36 +0100 [thread overview]
Message-ID: <YYkpxML6243IkbeK@lunn.ch> (raw)
In-Reply-To: <BY3PR18MB4612A7CB285470543A6A3C3CAB919@BY3PR18MB4612.namprd18.prod.outlook.com>
> Hello Jakub et al,
>
> Just following up based on the comments put by Ariel a week
> back. The earlier firmware has caused some important regression
> w.r.t SR-IOV compatibility, so it's critical to have these new FW
> patches to be accepted sooner (thinking of the impact on various
> Linux distributions/kernels where that bug/regression will be
> carried over with earlier firmware), as Ariel pointed out the
> complexities, in general making the FW backwards compatible on these
> devices architecture meaning supporting different data/control path
> (which is not good from performance perspective), However these two
> particular versions are not changing that much (from data/control
> path perspective) so we could have made them backward compatible for
> these two particular versions but given the time criticality,
> regression/bug introduced by the earlier FW, bnx2x devices being
> almost EOL, this would be our last FW submission hopefully so we
> don't want to re-invent something which has been continued for many
> years now for these bnx2* devices.
> PS: this series was not meant for stable (I have Cced stable
> mistakenly), please let me know if I can send v2 with stable removed
> from recipients.
I'm i right in says, the bad firmware was introduced with:
commit 0a6890b9b4df89a83678eba0bee3541bcca8753c
Author: Sudarsana Reddy Kalluru <skalluru@marvell•com>
Date: Mon Nov 4 21:51:09 2019 -0800
bnx2x: Utilize FW 7.13.15.0.
Commit 97a27d6d6e8d "bnx2x: Add FW 7.13.15.0" added said .bin FW to
linux-firmware tree. This FW addresses few important issues in the earlier
FW release.
This patch incorporates FW 7.13.15.0 in the bnx2x driver.
And that means v5.5 through to at least 5.16 will be broken? It has
been broken for a little under 2 years? And both 5.10 and 5.15 are
LTS. And you don't care. You will leave them broken, even knowing that
distribution kernels are going to use these LTS kernel?
And you could of avoided this by not breaking the firmware ABI. Which
you now say is actually possible. And after being broken for 2 years
it is now time critical?
Andrew
next prev parent reply other threads:[~2021-11-08 13:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 19:37 [PATCH net-next 1/2] bnx2x: Utilize firmware 7.13.20.0 Manish Chopra
2021-10-26 19:37 ` [PATCH net-next 2/2] bnx2x: Invalidate fastpath HSI version for VFs Manish Chopra
2021-10-26 20:05 ` Greg KH
2021-10-26 20:05 ` [PATCH net-next 1/2] bnx2x: Utilize firmware 7.13.20.0 Greg KH
2021-10-26 20:30 ` [EXT] " Manish Chopra
2021-10-27 5:01 ` Greg KH
2021-10-26 21:07 ` Jakub Kicinski
2021-10-27 5:17 ` [EXT] " Ariel Elior
2021-10-27 12:18 ` Andrew Lunn
2021-10-27 14:03 ` Jakub Kicinski
2021-10-27 14:39 ` Andrew Lunn
2021-10-28 8:31 ` Ariel Elior
2021-11-08 11:02 ` Manish Chopra
2021-11-08 13:44 ` Andrew Lunn [this message]
2021-11-08 15:44 ` Ariel Elior
2021-11-08 21:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYkpxML6243IkbeK@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=GR-everest-linux-l2@marvell$(echo .)com \
--cc=aelior@marvell$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=malin1024@gmail$(echo .)com \
--cc=manishc@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=njavali@marvell$(echo .)com \
--cc=okulkarni@marvell$(echo .)com \
--cc=skalluru@marvell$(echo .)com \
--cc=smalin@marvell$(echo .)com \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox