From: Christoph Hellwig <hch@infradead•org>
To: Ilias Apalodimas <ilias.apalodimas@linaro•org>
Cc: Christoph Hellwig <hch@infradead•org>,
Yunsheng Lin <linyunsheng@huawei•com>,
Guillaume Tucker <guillaume.tucker@collabora•com>,
davem@davemloft•net, kuba@kernel•org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, linuxarm@openeuler•org,
hawk@kernel•org, akpm@linux-foundation•org, peterz@infradead•org,
will@kernel•org, jhubbard@nvidia•com, yuzhao@google•com,
mcroce@microsoft•com, fenghua.yu@intel•com, feng.tang@intel•com,
jgg@ziepe•ca, aarcange@redhat•com, guro@fb•com,
"kernelci@groups•io" <kernelci@groups•io>
Subject: Re: [PATCH net-next v6] page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA
Date: Mon, 15 Nov 2021 10:53:12 -0800 [thread overview]
Message-ID: <YZKsmCHWFUUtph2F@infradead.org> (raw)
In-Reply-To: <YZKrfvt01uTosWc8@apalos.home>
On Mon, Nov 15, 2021 at 08:48:30PM +0200, Ilias Apalodimas wrote:
> page_pool (the API in question), apart from allocating memory can manage
> the mappings for you. However while doing so it stores some parts (incl
> the dma addr) in struct page. The code in there could be simplified if
> we skipped support of the 'mapping' feature for 32-bit architectures with
> 64-bit DMA. We thought no driver was using the mapping feature (on 32bits)
> and cleaned up that part, but apparently we missed
> '32-bit -- LPAE -- page pool manages DMA mappings'
It is a very common configuration on various architectures, so I fear
you'll have to support it and undo the cleanup.
prev parent reply other threads:[~2021-11-16 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:19 [PATCH net-next v6] page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA Yunsheng Lin
2021-10-13 10:21 ` Jesper Dangaard Brouer
2021-10-15 10:00 ` patchwork-bot+netdevbpf
2021-11-09 9:58 ` Guillaume Tucker
2021-11-09 12:02 ` Yunsheng Lin
2021-11-12 9:21 ` Guillaume Tucker
2021-11-15 3:34 ` Yunsheng Lin
2021-11-15 11:53 ` Ilias Apalodimas
2021-11-15 12:10 ` Ilias Apalodimas
2021-11-15 12:21 ` Yunsheng Lin
2021-11-15 14:39 ` Jesper Dangaard Brouer
2021-11-15 18:55 ` Ilias Apalodimas
2021-11-17 11:52 ` Jesper Dangaard Brouer
2021-11-15 17:59 ` Christoph Hellwig
2021-11-15 18:48 ` Ilias Apalodimas
2021-11-15 18:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZKsmCHWFUUtph2F@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=aarcange@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=feng.tang@intel$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=guillaume.tucker@collabora$(echo .)com \
--cc=guro@fb$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=jgg@ziepe$(echo .)ca \
--cc=jhubbard@nvidia$(echo .)com \
--cc=kernelci@groups$(echo .)io \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxarm@openeuler$(echo .)org \
--cc=linyunsheng@huawei$(echo .)com \
--cc=mcroce@microsoft$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=will@kernel$(echo .)org \
--cc=yuzhao@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox