Subject: Re: [PATCH bpf] libbpf: fix missing section "sk_skb/skb_verdict"

From: Cong Wang <[email-masked]>
Date: Mon, 29 Nov 2021 12:50:57 -0800

On Fri, Nov 26, 2021 at 04:20:34PM -0800, Song Liu wrote:
> On Fri, Nov 26, 2021 at 12:45 PM Cong Wang <[email-masked]> wrote:
> >
> > From: Cong Wang <[email-masked]>
> >
> > When BPF_SK_SKB_VERDICT was introduced, I forgot to add
> > a section mapping for it in libbpf.
> >
> > Fixes: a7ba4558e69a ("sock_map: Introduce BPF_SK_SKB_VERDICT")
> > Cc: Daniel Borkmann <[email-masked]>
> > Cc: John Fastabend <[email-masked]>
> > Cc: Jakub Sitnicki <[email-masked]>
> > Signed-off-by: Cong Wang <[email-masked]>
> 
> The patch looks good to me. But seems the selftests are OK without this. So,
> do we really need this?
> 

Not sure if I understand this question.

At least BPF_SK_SKB_STREAM_PARSER and BPF_SK_SKB_STREAM_VERDICT are already
there, so either we should remove all of them or add BPF_SK_SKB_VERDICT for
completeness.

Or are you suggesting we should change it back in selftests too? Note, it was
changed by Andrii in commit 15669e1dcd75fe6d51e495f8479222b5884665b6:

-SEC("sk_skb/skb_verdict")
+SEC("sk_skb")

Thanks.