From: Matthias Kaehlcke <mka@chromium•org>
To: Alex Elder <elder@linaro•org>
Cc: davem@davemloft•net, kuba@kernel•org, jponduru@codeaurora•org,
avuyyuru@codeaurora•org, bjorn.andersson@linaro•org,
agross@kernel•org, cpratapa@codeaurora•org,
subashab@codeaurora•org, evgreen@chromium•org, elder@kernel•org,
netdev@vger•kernel.org, linux-arm-msm@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net 2/2] net: ipa: prevent concurrent replenish
Date: Tue, 11 Jan 2022 13:54:23 -0800 [thread overview]
Message-ID: <Yd38j7mR5vwqlSMZ@google.com> (raw)
In-Reply-To: <20220111192150.379274-3-elder@linaro.org>
On Tue, Jan 11, 2022 at 01:21:50PM -0600, Alex Elder wrote:
> We have seen cases where an endpoint RX completion interrupt arrives
> while replenishing for the endpoint is underway. This causes another
> instance of replenishing to begin as part of completing the receive
> transaction. If this occurs it can lead to transaction corruption.
>
> Use a new atomic variable to ensure only replenish instance for an
> endpoint executes at a time.
>
> Fixes: 84f9bd12d46db ("soc: qcom: ipa: IPA endpoints")
> Signed-off-by: Alex Elder <elder@linaro•org>
Reviewed-by: Matthias Kaehlcke <mka@chromium•org>
next prev parent reply other threads:[~2022-01-11 21:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 19:21 [PATCH net 0/2] net: ipa: fix two replenish bugs Alex Elder
2022-01-11 19:21 ` [PATCH net 1/2] net: ipa: fix atomic update in ipa_endpoint_replenish() Alex Elder
2022-01-11 20:05 ` Matthias Kaehlcke
2022-01-11 19:21 ` [PATCH net 2/2] net: ipa: prevent concurrent replenish Alex Elder
2022-01-11 20:20 ` Matthias Kaehlcke
2022-01-11 20:58 ` Alex Elder
2022-01-11 21:53 ` Matthias Kaehlcke
2022-01-11 21:54 ` Matthias Kaehlcke [this message]
2022-01-12 4:04 ` Jakub Kicinski
2022-01-12 13:16 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd38j7mR5vwqlSMZ@google.com \
--to=mka@chromium$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=avuyyuru@codeaurora$(echo .)org \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=cpratapa@codeaurora$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=elder@kernel$(echo .)org \
--cc=elder@linaro$(echo .)org \
--cc=evgreen@chromium$(echo .)org \
--cc=jponduru@codeaurora$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=subashab@codeaurora$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox