From: Greg KH <gregkh@linuxfoundation•org>
To: Aayush Agarwal <aayush.a.agarwal@oracle•com>
Cc: stable@vger•kernel.org, Hangyu Hua <hbh25y@gmail•com>,
Jakub Kicinski <kuba@kernel•org>,
Remi Denis-Courmont <courmisch@gmail•com>,
"David S. Miller" <davem@davemloft•net>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 4.14] phonet: refcount leak in pep_sock_accep
Date: Fri, 7 Jan 2022 12:24:02 +0100 [thread overview]
Message-ID: <Ydgi0qF/7GwoCh96@kroah.com> (raw)
In-Reply-To: <20220107105332.61347-1-aayush.a.agarwal@oracle.com>
On Fri, Jan 07, 2022 at 02:53:32AM -0800, Aayush Agarwal wrote:
> From: Hangyu Hua <hbh25y@gmail•com>
>
> commit bcd0f9335332 ("phonet: refcount leak in pep_sock_accep")
> upstream.
>
> sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
> invoked in subsequent failure branches(pep_accept_conn() != 0).
>
> Signed-off-by: Hangyu Hua <hbh25y@gmail•com>
> Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> Signed-off-by: Aayush Agarwal <aayush.a.agarwal@oracle•com>
> ---
> net/phonet/pep.c | 1 +
> 1 file changed, 1 insertion(+)
What about releases 5.15.y, 5.10.y, 5.4.y, and 4.19.y? Is this also
relevant for those trees?
thanks,
greg k-h
next prev parent reply other threads:[~2022-01-07 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 10:53 [PATCH 4.14] phonet: refcount leak in pep_sock_accep Aayush Agarwal
2022-01-07 11:24 ` Greg KH [this message]
2022-01-07 16:54 ` [External] : " aayush.a.agarwal
2022-01-09 13:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ydgi0qF/7GwoCh96@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=aayush.a.agarwal@oracle$(echo .)com \
--cc=courmisch@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hbh25y@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox