Subject: Re: [net-next:master 59/127] drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared; did you mean 'out'?

From: Leon Romanovsky <[email-masked]>
Date: Sun, 9 Jan 2022 11:35:14 +0200

On Sun, Jan 09, 2022 at 03:04:48AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
> head:   82192cb497f9eca6c0d44dbc173e68d59ea2f3c9
> commit: 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e [59/127] net/mlx5e: Expose FEC counters via ethtool
> config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20220109/[email-masked]/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?id=0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         git remote add net-next https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
>         git fetch --no-tags net-next master
>         git checkout 0a1498ebfa55b860e8ec929d73585bcd3fd81a4e
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email-masked]>
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c: In function 'fec_set_block_stats':
> >> drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: error: 'outl' undeclared (first use in this function); did you mean 'out'?
>     1235 |         if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
>          |                                                ^~~~
>          |                                                out
>    drivers/net/ethernet/mellanox/mlx5/core/en_stats.c:1235:48: note: each undeclared identifier is reported only once for each function it appears in
> 
> 
> vim +1235 drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
> 
>   1220	
>   1221	static void fec_set_block_stats(struct mlx5e_priv *priv,
>   1222					struct ethtool_fec_stats *fec_stats)
>   1223	{
>   1224		struct mlx5_core_dev *mdev = priv->mdev;
>   1225		u32 out[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1226		u32 in[MLX5_ST_SZ_DW(ppcnt_reg)] = {};
>   1227		int sz = MLX5_ST_SZ_BYTES(ppcnt_reg);
>   1228		int mode = fec_active_mode(mdev);
>   1229	
>   1230		if (mode == MLX5E_FEC_NOFEC)
>   1231			return;
>   1232	
>   1233		MLX5_SET(ppcnt_reg, in, local_port, 1);
>   1234		MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
> > 1235		if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))

Obviously, this should be "out" and not "outl".

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
index 7e7c0c1019f6..26e326fe503c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
@@ -1232,7 +1232,7 @@ static void fec_set_block_stats(struct mlx5e_priv *priv,

        MLX5_SET(ppcnt_reg, in, local_port, 1);
        MLX5_SET(ppcnt_reg, in, grp, MLX5_PHYSICAL_LAYER_COUNTERS_GROUP);
-       if (mlx5_core_access_reg(mdev, in, sz, outl, sz, MLX5_REG_PPCNT, 0, 0))
+       if (mlx5_core_access_reg(mdev, in, sz, out, sz, MLX5_REG_PPCNT, 0, 0))
                return;

        switch (mode) {

>   1236			return;
>   1237	
>   1238		switch (mode) {
>   1239		case MLX5E_FEC_RS_528_514:
>   1240		case MLX5E_FEC_RS_544_514:
>   1241		case MLX5E_FEC_LLRS_272_257_1:
>   1242			fec_set_rs_stats(fec_stats, out);
>   1243			return;
>   1244		case MLX5E_FEC_FIRECODE:
>   1245			fec_set_fc_stats(fec_stats, out, fec_num_lanes(mdev));
>   1246		}
>   1247	}
>   1248	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/[email-masked]