Subject: Re: [RFC PATCH net-next 1/2] net: dsa: remove ndo_get_phys_port_name and ndo_get_port_parent_id

From: Ido Schimmel <[email-masked]>
Date: Sun, 9 Jan 2022 19:25:38 +0200

On Fri, Jan 07, 2022 at 08:48:41PM +0200, Vladimir Oltean wrote:
> There are no legacy ports, DSA registers a devlink instance with ports
> unconditionally for all switch drivers. Therefore, delete the old-style
> ndo operations used for determining bridge forwarding domains.
> 
> Signed-off-by: Vladimir Oltean <[email-masked]>

Looks correct to me.

If ndo_get_phys_port_name() is not implemented, then
devlink_compat_phys_port_name_get() is called which invokes
ndo_get_devlink_port() that you have implemented. Similarly, for
ndo_get_port_parent_id().

Reviewed-by: Ido Schimmel <[email-masked]>