From: Andrew Lunn <andrew@lunn•ch>
To: Sergei Trofimovich <slyich@gmail•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>, netdev@vger•kernel.org
Subject: Re: atl1c drivers run 'napi/eth%d-385' named threads with unsubstituted %d
Date: Sat, 22 Jan 2022 16:54:45 +0100 [thread overview]
Message-ID: <YewoxYh2jNBnanUM@lunn.ch> (raw)
In-Reply-To: <20220122121228.3b73db2a@nz>
> Thank you Andrew! I used this second version of your patch
> against 5.16.1 and it seems to work:
>
> $ sudo ping -f 172.16.0.1
>
> 613 root 20 0 0 0 0 S 11.0 0.0 0:07.46 napi/eth0-385
> 614 root 20 0 0 0 0 R 5.3 0.0 0:03.96 napi/eth0-386
>
> Posting used diff as is just in case:
>
> Tested-by: Sergei Trofimovich <slyich@gmail•com>
Great, thanks for testing.
>
> --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
> @@ -2706,6 +2706,15 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> goto err_alloc_etherdev;
> }
>
> + if (rtnl_lock_killable()) {
> + err = -EINTR;
> + goto err_init_netdev;
> + }
> + err = dev_alloc_name(netdev, netdev->name);
> + rtnl_unlock();
> + if (err < 0)
> + goto err_init_netdev;
Since there are multiple users of dev_alloc_name() and it appears some
get locking wrong, it makes sense to add a helper in the code which
does the locking. So i will work on a patchset to add such a helper
and convert other drivers.
Andrew
next prev parent reply other threads:[~2022-01-22 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 21:57 atl1c drivers run 'napi/eth%d-385' named threads with unsubstituted %d Sergei Trofimovich
2022-01-21 23:45 ` Andrew Lunn
2022-01-22 1:03 ` Stephen Hemminger
2022-01-22 1:53 ` Andrew Lunn
2022-01-22 12:12 ` Sergei Trofimovich
2022-01-22 15:54 ` Andrew Lunn [this message]
2022-01-22 19:40 ` Andrew Lunn
2022-01-22 22:01 ` Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YewoxYh2jNBnanUM@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=netdev@vger$(echo .)kernel.org \
--cc=slyich@gmail$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox