From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Joe Perches <joe@perches•com>
Cc: nick.hawkins@hpe•com, verdun@hpe•com,
"David Airlie" <airlied@linux•ie>,
"Daniel Vetter" <daniel@ffwll•ch>,
"Rob Herring" <robh+dt@kernel•org>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Bartosz Golaszewski" <brgl@bgdev•pl>,
"Corey Minyard" <minyard@acm•org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@canonical•com>,
"Miquel Raynal" <miquel.raynal@bootlin•com>,
"Richard Weinberger" <richard@nod•at>,
"Vignesh Raghavendra" <vigneshr@ti•com>,
"David S. Miller" <davem@davemloft•net>,
"Jakub Kicinski" <kuba@kernel•org>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Lee Jones" <lee.jones@linaro•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Mark Brown" <broonie@kernel•org>,
"Rafael J. Wysocki" <rafael@kernel•org>,
"Daniel Lezcano" <daniel.lezcano@linaro•org>,
"Amit Kucheria" <amitk@kernel•org>,
"Zhang Rui" <rui.zhang@intel•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Wim Van Sebroeck" <wim@linux-watchdog•org>,
"Guenter Roeck" <linux@roeck-us•net>,
"Arnd Bergmann" <arnd@arndb•de>,
"Olof Johansson" <olof@lixom•net>,
soc@kernel•org, "Shawn Guo" <shawnguo@kernel•org>,
"Stanislav Jakubek" <stano.jakubek@gmail•com>,
"Sam Ravnborg" <sam@ravnborg•org>,
"Hao Fang" <fanghao11@huawei•com>,
"Mark Rutland" <mark.rutland@arm•com>,
"Marc Zyngier" <maz@kernel•org>,
"Ard Biesheuvel" <ardb@kernel•org>,
"Anshuman Khandual" <anshuman.khandual@arm•com>,
"Wang Kefeng" <wangkefeng.wang@huawei•com>,
"Lukas Bulwahn" <lukas.bulwahn@gmail•com>,
"Masahiro Yamada" <masahiroy@kernel•org>,
dri-devel@lists•freedesktop.org, devicetree@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-gpio@vger•kernel.org,
linux-i2c@vger•kernel.org,
openipmi-developer@lists•sourceforge.net,
linux-mtd@lists•infradead.org, netdev@vger•kernel.org,
linux-pwm@vger•kernel.org, linux-serial@vger•kernel.org,
linux-spi@vger•kernel.org, linux-pm@vger•kernel.org,
linux-usb@vger•kernel.org, linux-watchdog@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] HPE BMC GXP SUPPORT
Date: Fri, 4 Feb 2022 12:31:06 +0000 [thread overview]
Message-ID: <Yf0cihUQ1byjnh3d@shell.armlinux.org.uk> (raw)
In-Reply-To: <ad56e88206a8d66b715035362abe16ece0bde7d3.camel@perches.com>
On Fri, Feb 04, 2022 at 04:18:24AM -0800, Joe Perches wrote:
> On Fri, 2022-02-04 at 12:05 +0000, Russell King (Oracle) wrote:
> > On Wed, Feb 02, 2022 at 10:52:50AM -0600, nick.hawkins@hpe•com wrote:
> > > + if (readb_relaxed(timer->control) & MASK_TCS_TC) {
> > > + writeb_relaxed(MASK_TCS_TC, timer->control);
> > > +
> > > + event_handler = READ_ONCE(timer->evt.event_handler);
> > > + if (event_handler)
> > > + event_handler(&timer->evt);
> > > + return IRQ_HANDLED;
> > > + } else {
> > > + return IRQ_NONE;
> > > + }
> > > +}
>
> It's also less indented code and perhaps clearer to reverse the test
>
> if (!readb_relaxed(timer->control) & MASK_TCS_TC)
This will need to be:
if (!(readb_relaxed(timer->control) & MASK_TCS_TC))
> return IRQ_NONE;
>
> writeb_relaxed(MASK_TCS_TC, timer->control);
>
> event_handler = READ_ONCE(timer->evt.event_handler);
> if (event_handler)
> event_handler(&timer->evt);
>
> return IRQ_HANDLED;
>
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-02-04 12:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 16:52 [PATCH] HPE BMC GXP SUPPORT nick.hawkins
2022-02-02 17:56 ` Corey Minyard
2022-02-02 18:14 ` Verdun, Jean-Marie
2022-02-02 21:21 ` Arnd Bergmann
2022-02-02 22:10 ` [Openipmi-developer] " Corey Minyard
2022-02-02 18:14 ` Sam Ravnborg
2022-02-03 1:10 ` Andrew Lunn
2022-02-03 7:41 ` Krzysztof Kozlowski
[not found] ` <CAL_Jsq+K2t5WYE056so1iZgZr7CBKvDEjAwnJVTyUFQcK-VFSA@mail.gmail.com>
2022-02-03 14:55 ` Krzysztof Kozlowski
2022-02-03 17:07 ` Verdun, Jean-Marie
2022-02-04 8:52 ` Krzysztof Kozlowski
2022-02-04 12:05 ` Russell King (Oracle)
2022-02-04 12:18 ` Joe Perches
2022-02-04 12:31 ` Russell King (Oracle) [this message]
2022-02-04 14:01 ` Joe Perches
2022-02-04 13:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yf0cihUQ1byjnh3d@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=airlied@linux$(echo .)ie \
--cc=amitk@kernel$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=ardb@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=brgl@bgdev$(echo .)pl \
--cc=broonie@kernel$(echo .)org \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=fanghao11@huawei$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=joe@perches$(echo .)com \
--cc=krzysztof.kozlowski@canonical$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=lee.jones@linaro$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-i2c@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=linux-usb@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@roeck-us$(echo .)net \
--cc=lukas.bulwahn@gmail$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=maz@kernel$(echo .)org \
--cc=minyard@acm$(echo .)org \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nick.hawkins@hpe$(echo .)com \
--cc=olof@lixom$(echo .)net \
--cc=openipmi-developer@lists$(echo .)sourceforge.net \
--cc=rafael@kernel$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=robh+dt@kernel$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
--cc=sam@ravnborg$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=soc@kernel$(echo .)org \
--cc=stano.jakubek@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thierry.reding@gmail$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=verdun@hpe$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox