Subject: Re: [PATCH v16, 2/2] net: Add dm9051 driver

From: Leon Romanovsky <[email-masked]>
Date: Sun, 30 Jan 2022 20:35:57 +0200

On Sun, Jan 30, 2022 at 12:43:46AM +0800, Joseph CHAMG wrote:
> Add davicom dm9051 spi ethernet driver, The driver work for the
> device platform which has the spi master
> 
> Signed-off-by: Joseph CHAMG <[email-masked]>
> ---
> Cc: Jakub Kicinski <[email-masked]>
> Cc: Andrew Lunn <[email-masked]>
> Cc: Leon Romanovsky <[email-masked]>
> Cc: andy Shevchenko <[email-masked]>

<...>

> +static int dm9051_probe(struct spi_device *spi)
> +{
> +	struct device *dev = &spi->dev;
> +	struct net_device *ndev;
> +	struct board_info *db;
> +	int ret = 0;

<...>

> +	kthread_init_worker(&db->kw);
> +	kthread_init_work(&db->kw_rxctrl, dm9051_rxctl_delay);
> +	kthread_init_work(&db->kw_tx, dm9051_tx_delay);
> +
> +	db->kwr_task_kw = kthread_run(kthread_worker_fn, &db->kw, "dm9051");

It is very unlikely that simple driver like this will need kthreads, does it really need?

Thanks