From: Rob Herring <robh@kernel•org>
To: "Marek Behún" <kabel@kernel•org>
Cc: Kishon Vijay Abraham I <kishon@ti•com>,
Vladimir Oltean <olteanv@gmail•com>,
Rob Herring <robh+dt@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
devicetree@vger•kernel.org,
Russell King <rmk+kernel@armlinux•org.uk>,
Vinod Koul <vkoul@kernel•org>, Andrew Lunn <andrew@lunn•ch>,
Holger Brunck <holger.brunck@hitachienergy•com>,
linux-phy@lists•infradead.org
Subject: Re: [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding
Date: Mon, 7 Feb 2022 14:30:51 -0600 [thread overview]
Message-ID: <YgGBe0BS/d0lOVtU@robh.at.kernel.org> (raw)
In-Reply-To: <20220119131117.30245-1-kabel@kernel.org>
On Wed, 19 Jan 2022 14:11:17 +0100, Marek Behún wrote:
> Common PHYs and network PCSes often have the possibility to specify
> peak-to-peak voltage on the differential pair - the default voltage
> sometimes needs to be changed for a particular board.
>
> Add properties `tx-p2p-microvolt` and `tx-p2p-microvolt-names` for this
> purpose. The second property is needed to specify the mode for the
> corresponding voltage in the `tx-p2p-microvolt` property, if the voltage
> is to be used only for speficic mode. More voltage-mode pairs can be
> specified.
>
> Example usage with only one voltage (it will be used for all supported
> PHY modes, the `tx-p2p-microvolt-names` property is not needed in this
> case):
>
> tx-p2p-microvolt = <915000>;
>
> Example usage with voltages for multiple modes:
>
> tx-p2p-microvolt = <915000>, <1100000>, <1200000>;
> tx-p2p-microvolt-names = "2500base-x", "usb", "pcie";
>
> Add these properties into a separate file phy/transmit-amplitude.yaml,
> which should be referenced by any binding that uses it.
>
> Signed-off-by: Marek Behún <kabel@kernel•org>
> ---
> Change since v2:
> - removed 'select:' as requested by Rob. Instead the schema should be
> referenced by any binding that uses it. This also fixed indentation
> warnings from Rob's bot, since they warned about lines in the select
> statement
> ---
> .../bindings/phy/transmit-amplitude.yaml | 103 ++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/transmit-amplitude.yaml
>
Reviewed-by: Rob Herring <robh@kernel•org>
prev parent reply other threads:[~2022-02-07 20:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 13:11 [PATCH devicetree v3] dt-bindings: phy: Add `tx-p2p-microvolt` property binding Marek Behún
2022-01-20 8:49 ` Marc Kleine-Budde
2022-01-20 18:01 ` Marek Behún
2022-01-20 19:50 ` Marc Kleine-Budde
2022-01-21 19:18 ` Florian Fainelli
2022-02-05 2:18 ` Rob Herring
2022-02-05 3:18 ` Florian Fainelli
2022-02-06 17:54 ` Marek Behún
2022-02-07 5:29 ` Vinod Koul
2022-02-07 20:30 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgGBe0BS/d0lOVtU@robh.at.kernel.org \
--to=robh@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=holger.brunck@hitachienergy$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kishon@ti$(echo .)com \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh+dt@kernel$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox