From: Ido Schimmel <idosch@idosch•org>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: Jianbo Liu <jianbol@nvidia•com>,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
linux-rdma@vger•kernel.org, andrew@lunn•ch,
vivien.didelot@gmail•com, f.fainelli@gmail•com,
davem@davemloft•net, kuba@kernel•org, rajur@chelsio•com,
claudiu.manoil@nxp•com, sgoutham@marvell•com, gakula@marvell•com,
sbhatta@marvell•com, hkelam@marvell•com, saeedm@nvidia•com,
leon@kernel•org, idosch@nvidia•com, petrm@nvidia•com,
alexandre.belloni@bootlin•com, UNGLinuxDriver@microchip•com,
simon.horman@corigine•com, jhs@mojatatu•com,
xiyou.wangcong@gmail•com, jiri@resnulli•us,
baowen.zheng@corigine•com, louis.peens@netronome•com,
peng.zhang@corigine•com, oss-drivers@corigine•com,
roid@nvidia•com
Subject: Re: [PATCH net-next v3 1/2] net: flow_offload: add tc police action parameters
Date: Thu, 17 Mar 2022 21:37:15 +0200 [thread overview]
Message-ID: <YjON61Hum0+B4m6y@shredder> (raw)
In-Reply-To: <20220317185249.5mff5u2x624pjewv@skbuf>
On Thu, Mar 17, 2022 at 08:52:49PM +0200, Vladimir Oltean wrote:
> I'd just like the 'reclassify' action to be propagated in some reasonable
> way to flow offload, considering that at the moment the error is quite cryptic.
OK, will check next week. Might be best to simply propagate extack to
offload_act_setup() and return a meaningful message in
tcf_police_offload_act_setup(). There are a bunch of other actions whose
callback simply returns '-EOPNOTSUPP' that can benefit from it.
next prev parent reply other threads:[~2022-03-17 19:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 10:29 [PATCH net-next v3 0/2] flow_offload: add tc police parameters Jianbo Liu
2022-02-24 10:29 ` [PATCH net-next v3 1/2] net: flow_offload: add tc police action parameters Jianbo Liu
2022-03-15 19:13 ` Vladimir Oltean
2022-03-17 13:22 ` Ido Schimmel
2022-03-17 18:52 ` Vladimir Oltean
2022-03-17 19:37 ` Ido Schimmel [this message]
2022-03-22 10:13 ` Ido Schimmel
2022-04-06 14:30 ` Vladimir Oltean
2022-02-24 10:29 ` [PATCH net-next v3 2/2] flow_offload: reject offload for all drivers with invalid police parameters Jianbo Liu
2022-02-28 11:40 ` [PATCH net-next v3 0/2] flow_offload: add tc " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjON61Hum0+B4m6y@shredder \
--to=idosch@idosch$(echo .)org \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=baowen.zheng@corigine$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=hkelam@marvell$(echo .)com \
--cc=idosch@nvidia$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jianbol@nvidia$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=leon@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=louis.peens@netronome$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=oss-drivers@corigine$(echo .)com \
--cc=peng.zhang@corigine$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=rajur@chelsio$(echo .)com \
--cc=roid@nvidia$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=simon.horman@corigine$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox