Subject: Re: [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported

From: "Russell King (Oracle)" <[email-masked]>
Date: Thu, 7 Apr 2022 15:47:10 +0100

On Wed, Apr 06, 2022 at 10:34:43PM +0200, Marek Behún wrote:
> On Wed, 6 Apr 2022 11:52:50 -0700
> Jakub Kicinski <[email-masked]> wrote:
> 
> > On Wed, 06 Apr 2022 11:48:57 +0100 Russell King (Oracle) wrote:
> > > -	if (state->interface != PHY_INTERFACE_MODE_MII) {
> > > +	if (state->interface != PHY_INTERFACE_MODE_MII &&
> > > +	    state->interface != PHY_INTERFACE_MODE_2500BASEX)
> > >  		phylink_set(mask, 1000baseT_Full);
> > >  		phylink_set(mask, 1000baseX_Full);
> > >  	}  
> > 
> > Missing { here. Dunno if kbuild bot told you already.
> 
> Probably not, because next patch removes this code entirely :)

kbuild bot normally does catch these if I've missed them locally, but
I find the bot is very very sporadic. Thanks for spotting it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!