From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Haowen Bai <baihaowen@meizu•com>
Cc: peterz@infradead•org, mingo@redhat•com, mark.rutland@arm•com,
alexander.shishkin@linux•intel.com, jolsa@kernel•org,
namhyung@kernel•org, ast@kernel•org, daniel@iogearbox•net,
andrii@kernel•org, kafai@fb•com, songliubraving@fb•com,
yhs@fb•com, john.fastabend@gmail•com, kpsingh@kernel•org,
linux-perf-users@vger•kernel.org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, bpf@vger•kernel.org
Subject: Re: [PATCH] perf evlist: Directly return instead of using local ret variable
Date: Wed, 30 Mar 2022 17:37:15 -0300 [thread overview]
Message-ID: <YkS/ez1o9QC2AcJ5@kernel.org> (raw)
In-Reply-To: <1648432532-23151-1-git-send-email-baihaowen@meizu.com>
Em Mon, Mar 28, 2022 at 09:55:32AM +0800, Haowen Bai escreveu:
> fixes coccinelle warning:
> ./tools/perf/util/evlist.c:1333:5-8: Unneeded variable: "err". Return
> "- ENOMEM" on line 1358
Thanks, applied.
- Arnaldo
> Signed-off-by: Haowen Bai <baihaowen@meizu•com>
> ---
> tools/perf/util/evlist.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index 9bb79e0..1883278 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -1330,7 +1330,6 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
> {
> struct perf_cpu_map *cpus;
> struct perf_thread_map *threads;
> - int err = -ENOMEM;
>
> /*
> * Try reading /sys/devices/system/cpu/online to get
> @@ -1355,7 +1354,7 @@ static int evlist__create_syswide_maps(struct evlist *evlist)
> out_put:
> perf_cpu_map__put(cpus);
> out:
> - return err;
> + return -ENOMEM;
> }
>
> int evlist__open(struct evlist *evlist)
> --
> 2.7.4
--
- Arnaldo
prev parent reply other threads:[~2022-03-30 20:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 1:55 [PATCH] perf evlist: Directly return instead of using local ret variable Haowen Bai
2022-03-30 20:37 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkS/ez1o9QC2AcJ5@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=baihaowen@meizu$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=songliubraving@fb$(echo .)com \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox