From: Arnaldo Carvalho de Melo <acme@kernel•org>
To: Ian Rogers <irogers@google•com>
Cc: Peter Zijlstra <peterz@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Mark Rutland <mark.rutland@arm•com>,
Alexander Shishkin <alexander.shishkin@linux•intel.com>,
Jiri Olsa <jolsa@kernel•org>, Namhyung Kim <namhyung@kernel•org>,
Mathieu Poirier <mathieu.poirier@linaro•org>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Mike Leach <mike.leach@linaro•org>, Leo Yan <leo.yan@linaro•org>,
John Garry <john.garry@huawei•com>, Will Deacon <will@kernel•org>,
Alexei Starovoitov <ast@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Andrii Nakryiko <andrii@kernel•org>,
Martin KaFai Lau <kafai@fb•com>, Song Liu <songliubraving@fb•com>,
Yonghong Song <yhs@fb•com>,
John Fastabend <john.fastabend@gmail•com>,
KP Singh <kpsingh@kernel•org>, Kajol Jain <kjain@linux•ibm.com>,
James Clark <james.clark@arm•com>,
German Gomez <german.gomez@arm•com>,
Adrian Hunter <adrian.hunter@intel•com>,
Riccardo Mancini <rickyman7@gmail•com>,
Andi Kleen <ak@linux•intel.com>,
Alexey Bayduraev <alexey.v.bayduraev@linux•intel.com>,
Alexander Antonov <alexander.antonov@linux•intel.com>,
linux-perf-users@vger•kernel.org, linux-kernel@vger•kernel.org,
coresight@lists•linaro.org, linux-arm-kernel@lists•infradead.org,
netdev@vger•kernel.org, bpf@vger•kernel.org,
Stephane Eranian <eranian@google•com>
Subject: Re: [PATCH v2 4/6] perf cpumap: More cpu map reuse by merge.
Date: Wed, 30 Mar 2022 17:34:42 -0300 [thread overview]
Message-ID: <YkS+4iGPdZixhbcn@kernel.org> (raw)
In-Reply-To: <20220328232648.2127340-5-irogers@google.com>
Em Mon, Mar 28, 2022 at 04:26:46PM -0700, Ian Rogers escreveu:
> perf_cpu_map__merge will reuse one of its arguments if they are equal or
> the other argument is NULL. The arguments could be reused if it is known
> one set of values is a subset of the other. For example, a map of 0-1
> and a map of just 0 when merged yields the map of 0-1. Currently a new
> map is created rather than adding a reference count to the original 0-1
> map.
Thanks, applied.
- Arnaldo
> Signed-off-by: Ian Rogers <irogers@google•com>
> ---
> tools/lib/perf/cpumap.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/tools/lib/perf/cpumap.c b/tools/lib/perf/cpumap.c
> index 23701024e0c0..384d5e076ee4 100644
> --- a/tools/lib/perf/cpumap.c
> +++ b/tools/lib/perf/cpumap.c
> @@ -355,17 +355,12 @@ struct perf_cpu_map *perf_cpu_map__merge(struct perf_cpu_map *orig,
> int i, j, k;
> struct perf_cpu_map *merged;
>
> - if (!orig && !other)
> - return NULL;
> - if (!orig) {
> - perf_cpu_map__get(other);
> - return other;
> - }
> - if (!other)
> - return orig;
> - if (orig->nr == other->nr &&
> - !memcmp(orig->map, other->map, orig->nr * sizeof(struct perf_cpu)))
> + if (perf_cpu_map__is_subset(orig, other))
> return orig;
> + if (perf_cpu_map__is_subset(other, orig)) {
> + perf_cpu_map__put(orig);
> + return perf_cpu_map__get(other);
> + }
>
> tmp_len = orig->nr + other->nr;
> tmp_cpus = malloc(tmp_len * sizeof(struct perf_cpu));
> --
> 2.35.1.1021.g381101b075-goog
--
- Arnaldo
next prev parent reply other threads:[~2022-03-30 20:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 23:26 [PATCH v2 0/6] Make evlist CPUs more accurate Ian Rogers
2022-03-28 23:26 ` [PATCH v2 1/6] perf stat: Avoid segv if core.user_cpus isn't set Ian Rogers
2022-03-28 23:26 ` [PATCH v2 2/6] perf evlist: Rename cpus to user_requested_cpus Ian Rogers
2022-03-30 20:31 ` Arnaldo Carvalho de Melo
2022-03-28 23:26 ` [PATCH v2 3/6] perf cpumap: Add is_subset function Ian Rogers
2022-03-30 20:34 ` Arnaldo Carvalho de Melo
2022-03-28 23:26 ` [PATCH v2 4/6] perf cpumap: More cpu map reuse by merge Ian Rogers
2022-03-30 20:34 ` Arnaldo Carvalho de Melo [this message]
2022-03-28 23:26 ` [PATCH v2 5/6] perf cpumap: Add intersect function Ian Rogers
2022-04-01 19:12 ` Arnaldo Carvalho de Melo
2022-03-28 23:26 ` [PATCH v2 6/6] perf evlist: Respect all_cpus when setting user_requested_cpus Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkS+4iGPdZixhbcn@kernel.org \
--to=acme@kernel$(echo .)org \
--cc=adrian.hunter@intel$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=alexander.antonov@linux$(echo .)intel.com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=alexey.v.bayduraev@linux$(echo .)intel.com \
--cc=andrii@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=bpf@vger$(echo .)kernel.org \
--cc=coresight@lists$(echo .)linaro.org \
--cc=daniel@iogearbox$(echo .)net \
--cc=eranian@google$(echo .)com \
--cc=german.gomez@arm$(echo .)com \
--cc=irogers@google$(echo .)com \
--cc=james.clark@arm$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=john.garry@huawei$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kafai@fb$(echo .)com \
--cc=kjain@linux$(echo .)ibm.com \
--cc=kpsingh@kernel$(echo .)org \
--cc=leo.yan@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mathieu.poirier@linaro$(echo .)org \
--cc=mike.leach@linaro$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peterz@infradead$(echo .)org \
--cc=rickyman7@gmail$(echo .)com \
--cc=songliubraving@fb$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=yhs@fb$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox