From: "Jason A. Donenfeld" <Jason@zx2c4•com>
To: Florent Fourcot <florent.fourcot@wifirst•fr>
Cc: netdev@vger•kernel.org, cong.wang@bytedance•com, edumazet@google•com
Subject: Re: [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage
Date: Tue, 19 Apr 2022 13:50:46 +0200 [thread overview]
Message-ID: <Yl6iFqPFrdvD1wam@zx2c4.com> (raw)
In-Reply-To: <20220415165330.10497-1-florent.fourcot@wifirst.fr>
Hi Florent,
On Fri, Apr 15, 2022 at 06:53:26PM +0200, Florent Fourcot wrote:
> First commit forbids dangerous calls when both IFNAME and GROUP are
> given, since it can introduce unexpected behaviour when IFNAME does not
> match any interface.
>
> Second patch achieves primary goal of this patchset to fix/improve
> IFLA_ALT_IFNAME attribute, since previous code was never working for
> newlink/setlink. ip-link command is probably getting interface index
> before, and was not using this feature.
>
> Last two patches are improving error code on corner cases.
This was just merged to net-next and appears to have broken the
wireguard test suite over on https://build.wireguard.com/
[+] Launching tests...
[ 0.796066] init.sh (28) used greatest stack depth: 29152 bytes left
[ 0.803809] ip (29) used greatest stack depth: 28544 bytes left
[+] ip netns add wg-test-27-0
[+] ip netns add wg-test-27-1
[ 0.842841] ip (32) used greatest stack depth: 27512 bytes left
[+] ip netns add wg-test-27-2
[+] NS0: ip link set up dev lo
[+] NS0: ip link add dev wg0 type wireguard
[ 0.896074] ip (35) used greatest stack depth: 27152 bytes left
Command "add" is unknown, try "ip link help".
[+] NS0: ip link del dev wg0
[+] NS0: ip link del dev wg1
[+] NS1: ip link del dev wg0
[+] NS1: ip link del dev wg1
[+] NS2: ip link del dev wg0
[+] NS2: ip link del dev wg1
[+] ip netns del wg-test-27-1
[+] ip netns del wg-test-27-2
[+] ip netns del wg-test-27-0
[-] Tests failed with exit code 255! ☹
So apparently something goes wrong with "ip link add dev wg0 type
wireguard". Not quite sure what yet, though. You can try it for yourself
with:
make -C tools/testing/selftests/wireguard/qemu -j$(nproc)
Jason
next prev parent reply other threads:[~2022-04-19 11:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 16:53 [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 1/4] rtnetlink: return ENODEV when ifname does not exist and group is given Florent Fourcot
2022-04-15 19:24 ` Stephen Hemminger
2022-04-19 7:29 ` Florent Fourcot
2022-04-19 15:04 ` Stephen Hemminger
2022-04-15 16:53 ` [PATCH v5 net-next 2/4] rtnetlink: enable alt_ifname for setlink/newlink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 3/4] rtnetlink: return ENODEV when IFLA_ALT_IFNAME is used in dellink Florent Fourcot
2022-04-15 16:53 ` [PATCH v5 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed Florent Fourcot
2022-04-15 19:26 ` Stephen Hemminger
2022-04-19 7:29 ` Florent Fourcot
2022-04-22 1:27 ` Vinicius Costa Gomes
2022-04-15 19:03 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Jakub Kicinski
2022-04-19 11:50 ` patchwork-bot+netdevbpf
2022-04-19 11:50 ` Jason A. Donenfeld [this message]
2022-04-19 12:51 ` [PATCH net-next] Revert "rtnetlink: return EINVAL when request cannot succeed" Florent Fourcot
2022-04-20 14:48 ` Guillaume Nault
2022-04-21 1:15 ` Eric Dumazet
2022-04-22 10:10 ` patchwork-bot+netdevbpf
2022-04-19 14:25 ` [PATCH v5 net-next 0/4] rtnetlink: improve ALT_IFNAME config and fix dangerous GROUP usage Florent Fourcot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl6iFqPFrdvD1wam@zx2c4.com \
--to=jason@zx2c4$(echo .)com \
--cc=cong.wang@bytedance$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=florent.fourcot@wifirst$(echo .)fr \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox