Subject: Re: [PATCH v5 8/8] dt-bindings: net: dwmac-imx: Document clk_csr property

From: Abel Vesa <[email-masked]>
Date: Wed, 13 Apr 2022 10:36:55 +0300

On 22-04-06 13:04:13, Rob Herring wrote:
> On Mon, Apr 04, 2022 at 04:46:09PM +0300, Abel Vesa wrote:
> > The clk_csr property is used for CSR clock range selection.
>
> Why?

Well, this actually documented in
Documentation/networking/device_drivers/ethernet/stmicro/stmmac.rst.

But I think I'll just drop this one and remove the property from the
devicetree node for now. We'll figure it out later when the ethernet
support will be upstreamed.

>
> >
> > Signed-off-by: Abel Vesa <[email-masked]>
> > ---
> >  Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > index 011363166789..1556d95943f6 100644
> > --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> > @@ -32,6 +32,10 @@ properties:
> >                - nxp,imx8dxl-dwmac-eqos
> >            - const: snps,dwmac-5.10a
> >
> > +  clk_csr:
>
> s/_/-/
>
> vendor prefix needed.
>
> And a type is needed.
>
> > +    description: |
> > +      Fixed CSR Clock Range selection
>
> What? Explain all this to someone that doesn't know your h/w.
>
> > +
> >    clocks:
> >      minItems: 3
> >      items:
> > --
> > 2.34.1
> >
> >