From: Benjamin Poirier <benjamin.poirier@gmail•com>
To: Yihao Han <hanyihao@vivo•com>
Cc: Shahed Shaikh <shshaikh@marvell•com>,
Manish Chopra <manishc@marvell•com>,
GR-Linux-NIC-Dev@marvell•com,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@vivo•com
Subject: Re: [PATCH v2] net: qlogic: qlcnic: simplify if-if to if-else
Date: Sat, 16 Apr 2022 10:44:30 +0900 [thread overview]
Message-ID: <Yloffi2Og9bS2fds@d3> (raw)
In-Reply-To: <20220415120949.86169-1-hanyihao@vivo.com>
On 2022-04-15 05:09 -0700, Yihao Han wrote:
> Replace `if (!pause->autoneg)` with `else` for simplification
> according to the kernel coding style:
>
> "Do not unnecessarily use braces where a single statement will do."
>
> ...
>
> "This does not apply if only one branch of a conditional statement is
> a single statement; in the latter case use braces in both branches"
>
> Please refer to:
> https://www.kernel.org/doc/html/v5.17-rc8/process/coding-style.html
This commit log is even more confusing than v1. Only the first line is
correct.
>
> Suggested-by: Benjamin Poirier <benjamin.poirier@gmail•com>
I did not suggest this change. Please remove the tag.
> Signed-off-by: Yihao Han <hanyihao@vivo•com>
> ---
> v2:edit commit message
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> index bd0607680329..e3842eaf1532 100644
> --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c
> @@ -3752,7 +3752,7 @@ int qlcnic_83xx_set_pauseparam(struct qlcnic_adapter *adapter,
> if (ahw->port_type == QLCNIC_GBE) {
> if (pause->autoneg)
> ahw->port_config |= QLC_83XX_ENABLE_AUTONEG;
> - if (!pause->autoneg)
> + else
> ahw->port_config &= ~QLC_83XX_ENABLE_AUTONEG;
> } else if ((ahw->port_type == QLCNIC_XGBE) && (pause->autoneg)) {
> return -EOPNOTSUPP;
> --
> 2.17.1
>
prev parent reply other threads:[~2022-04-16 2:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 12:09 [PATCH v2] net: qlogic: qlcnic: simplify if-if to if-else Yihao Han
2022-04-16 1:44 ` Benjamin Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yloffi2Og9bS2fds@d3 \
--to=benjamin.poirier@gmail$(echo .)com \
--cc=GR-Linux-NIC-Dev@marvell$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=hanyihao@vivo$(echo .)com \
--cc=kernel@vivo$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=manishc@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=shshaikh@marvell$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox