From: Andrew Lunn <andrew@lunn•ch>
To: Robert Hancock <robert.hancock@calian•com>
Cc: netdev@vger•kernel.org, hkallweit1@gmail•com,
linux@armlinux•org.uk, davem@davemloft•net, kuba@kernel•org,
pabeni@redhat•com
Subject: Re: [PATCH net-next] net: phy: marvell: update abilities and advertising when switching to SGMII
Date: Fri, 29 Apr 2022 03:35:43 +0200 [thread overview]
Message-ID: <YmtA7/OjKIQD/vuD@lunn.ch> (raw)
In-Reply-To: <20220427193928.2155805-1-robert.hancock@calian.com>
On Wed, Apr 27, 2022 at 01:39:28PM -0600, Robert Hancock wrote:
> With some SFP modules, such as Finisar FCLF8522P2BTL, the PHY hardware
> strapping defaults to 1000BaseX mode, but the kernel prefers to set them
> for SGMII mode.
Is this the SFP code determining this? Its copper == use SGMII?
> When this happens and the PHY is soft reset, the BMSR
> status register is updated, but this happens after the kernel has already
> read the PHY abilities during probing. This results in support not being
> detected for, and the PHY not advertising support for, 10 and 100 Mbps
> modes, preventing the link from working with a non-gigabit link partner.
>
> When the PHY is being configured for SGMII mode, call genphy_read_abilities
> again in order to re-read the capabilities, and update the advertising
> field accordingly.
Is this actually a generic problem? There are other PHYs used in SFP
modules, and i assume they also could have their mode changed. So
should the re-reading of the abilities be in the core, not each
driver?
Andrew
next prev parent reply other threads:[~2022-04-29 1:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 19:39 [PATCH net-next] net: phy: marvell: update abilities and advertising when switching to SGMII Robert Hancock
2022-04-29 1:35 ` Andrew Lunn [this message]
2022-04-29 16:17 ` Russell King (Oracle)
2022-04-30 15:05 ` Andrew Lunn
2022-05-01 11:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmtA7/OjKIQD/vuD@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robert.hancock@calian$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox