From: Simon Horman <simon.horman@corigine•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, alexander.duyck@gmail•com,
stephen@networkplumber•org, gustavoars@kernel•org,
roopa@nvidia•com, keescook@chromium•org,
william.xuanziyang@huawei•com, lucien.xin@gmail•com,
oss-drivers@corigine•com
Subject: Re: [PATCH net-next 1/4] net: add netif_inherit_tso_max()
Date: Fri, 6 May 2022 20:27:38 +0900 [thread overview]
Message-ID: <YnUGKkx0cCi9c06M@corigine.com> (raw)
In-Reply-To: <20220506025134.794537-2-kuba@kernel.org>
On Thu, May 05, 2022 at 07:51:31PM -0700, Jakub Kicinski wrote:
> To make later patches smaller create a helper for inheriting
> the TSO limitations of a lower device. The TSO in the name
> is not an accident, subsequent patches will replace GSO
> with TSO in more names.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel•org>
> ---
> CC: simon.horman@corigine•com
> CC: gustavoars@kernel•org
> CC: roopa@nvidia•com
> CC: keescook@chromium•org
> CC: william.xuanziyang@huawei•com
> CC: lucien.xin@gmail•com
> CC: oss-drivers@corigine•com
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_repr.c | 3 +--
> drivers/net/ipvlan/ipvlan_main.c | 6 ++----
> drivers/net/macvlan.c | 6 ++----
> drivers/net/veth.c | 3 +--
> drivers/net/vxlan/vxlan_core.c | 3 +--
> include/linux/netdevice.h | 3 +++
> net/8021q/vlan.c | 3 +--
> net/8021q/vlan_dev.c | 3 +--
> net/core/dev.c | 12 ++++++++++++
> 9 files changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> index ba3fa7eac98d..790e1d5e4b4a 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_repr.c
> @@ -286,8 +286,7 @@ nfp_repr_transfer_features(struct net_device *netdev, struct net_device *lower)
> if (repr->dst->u.port_info.lower_dev != lower)
> return;
>
> - netif_set_gso_max_size(netdev, lower->gso_max_size);
> - netif_set_gso_max_segs(netdev, lower->gso_max_segs);
> + netif_inherit_tso_max(netdev, lower);
>
> netdev_update_features(netdev);
> }
NFP portion:
Reviewed-by: Simon Horman <simon.horman@corigine•com>
...
next prev parent reply other threads:[~2022-05-06 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 2:51 [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Jakub Kicinski
2022-05-06 2:51 ` [PATCH net-next 1/4] net: add netif_inherit_tso_max() Jakub Kicinski
2022-05-06 11:27 ` Simon Horman [this message]
2022-05-06 2:51 ` [PATCH net-next 2/4] net: don't allow user space to lift the device limits Jakub Kicinski
2022-05-06 2:51 ` [PATCH net-next 3/4] net: make drivers set the TSO limit not the GSO limit Jakub Kicinski
2022-05-06 11:30 ` Simon Horman
2022-05-09 14:31 ` Marcin Wojtas
2022-05-06 2:51 ` [PATCH net-next 4/4] net: move netif_set_gso_max helpers Jakub Kicinski
2022-05-06 2:58 ` [PATCH net-next 0/4] net: disambiguate the TSO and GSO limits Eric Dumazet
2022-05-06 11:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YnUGKkx0cCi9c06M@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=alexander.duyck@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=gustavoars@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=lucien.xin@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=roopa@nvidia$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=william.xuanziyang@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox