From: Andrew Lunn <andrew@lunn•ch>
To: Claudiu Manoil <claudiu.manoil@nxp•com>
Cc: Heiner Kallweit <hkallweit1@gmail•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
netdev@vger•kernel.org, Ondrej Spacek <ondrej.spacek@nxp•com>
Subject: Re: [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are not advertised
Date: Sat, 11 Jun 2022 16:59:49 +0200 [thread overview]
Message-ID: <YqSt5Rysq110xpA3@lunn.ch> (raw)
In-Reply-To: <20220610084037.7625-1-claudiu.manoil@nxp.com>
On Fri, Jun 10, 2022 at 11:40:37AM +0300, Claudiu Manoil wrote:
> Even when the eth port is resticted to work with speeds not higher than 1G,
> and so the eth driver is requesting the phy (via phylink) to advertise up
> to 1000BASET support, the aquantia phy device is still advertising for 2.5G
> and 5G speeds.
> Clear these advertising defaults when requested.
Hi Claudiu
genphy_c45_an_config_aneg(phydev) is called in aqr_config_aneg, which
should set/clear MDIO_AN_10GBT_CTRL_ADV5G and
MDIO_AN_10GBT_CTRL_ADV2_5G. Does the aQuantia PHY not have these bits?
Andrew
next prev parent reply other threads:[~2022-06-11 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 8:40 [PATCH, net] phy: aquantia: Fix AN when higher speeds than 1G are not advertised Claudiu Manoil
2022-06-11 14:59 ` Andrew Lunn [this message]
2022-06-11 18:13 ` Claudiu Manoil
2022-06-11 23:20 ` Andrew Lunn
2022-06-12 18:47 ` Claudiu Manoil
2022-06-12 21:25 ` Andrew Lunn
2022-06-14 14:08 ` Claudiu Manoil
2022-06-17 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqSt5Rysq110xpA3@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=ondrej.spacek@nxp$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox