From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Jakub Kicinski <kuba@kernel•org>
Cc: "Andrew Lunn" <andrew@lunn•ch>, "Marek Behún" <kabel@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
netdev@vger•kernel.org, "Paolo Abeni" <pabeni@redhat•com>,
"Robert Hancock" <robert.hancock@calian•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Vladimir Oltean" <olteanv@gmail•com>
Subject: Re: [PATCH net-next 02/15] net: phylink: add phylink_pcs_inband()
Date: Wed, 15 Jun 2022 09:16:54 +0100 [thread overview]
Message-ID: <YqmVdj4X5101PC1u@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220614224652.09d4c287@kernel.org>
On Tue, Jun 14, 2022 at 10:46:52PM -0700, Jakub Kicinski wrote:
> On Mon, 13 Jun 2022 14:00:31 +0100 Russell King (Oracle) wrote:
> > + if (phylink_autoneg_inband(mode) &&
> > + (interface == PHY_INTERFACE_MODE_SGMII ||
> > + interface == PHY_INTERFACE_MODE_QSGMII ||
> > + linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT, advertising)))
> > + return true;
> > + else
> > + return false;
>
> Okay, let me be a little annoying...
No, not annoying!
> Could you run thru checkpatch --strict and fix the few whitespace
> issues it points out? There's a handful of spaces instead of tabs,
> unaligned continuation lines and an unnecessary bracket.
That somewhat surprises me... will fix most of the strict errors,
except this one:
WARNING: function definition argument 'struct mv88e639x_pcs *' should also have
an identifier name
#337: FILE: drivers/net/dsa/mv88e6xxx/pcs-639x.c:93:
+ irqreturn_t (*handler)(struct mv88e639x_pcs *);
because its utterly pointless. What extra information would adding "pcs"
give to the reader? I can Understand it for standard C types because they
are opaque, but not for this.
> Patch 1 does not need to be backported so I presume it can lose the
> fixes tag?
As the commit talks about fixing something, in my experience the commit
will get automatically selected for backporting to stable trees whether
or not it has a fixes tag on it. The only way to stop that happening is
not through avoiding a fixes tag, but to keep on top of the stable tree
emails to stop patches being backported that don't need to be.
If you still want me to remove it, I will, but I predict it will still
be backported.
> The quoted code can be converted into a direct return of the condition,
> I don't really care but I think there are bots out there which will
> send a "fix" soon if we commit this.
>
> And patch 10 generates a transient "function should be static" warning.
> I think you need a __maybe_unused on mv88e6xxx_pcs_select() as well.
Gah, I did build-test each patch individually, but I guess because of
the time it takes to do so I must have not looked at the results
properly - will fix.
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-06-15 8:17 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 12:59 [PATCH net-next 00/15] net: dsa: mv88e6xxx: convert to phylink pcs Russell King (Oracle)
2022-06-13 13:00 ` [PATCH net-next 01/15] net: phylink: fix SGMII inband autoneg enable Russell King (Oracle)
2022-06-14 18:34 ` Andrew Lunn
2022-06-13 13:00 ` [PATCH net-next 02/15] net: phylink: add phylink_pcs_inband() Russell King (Oracle)
2022-06-14 18:35 ` Andrew Lunn
2022-06-15 5:46 ` Jakub Kicinski
2022-06-15 8:16 ` Russell King (Oracle) [this message]
2022-06-15 17:46 ` Jakub Kicinski
2022-06-15 18:07 ` Russell King (Oracle)
2022-06-13 13:00 ` [PATCH net-next 03/15] net: phylink: remove pcs_ops member Russell King (Oracle)
2022-06-14 18:36 ` Andrew Lunn
2022-06-13 13:00 ` [PATCH net-next 04/15] net: phylink: disable PCS polling over major configuration Russell King (Oracle)
2022-06-14 18:37 ` Andrew Lunn
2022-06-13 13:00 ` [PATCH net-next 05/15] net: phylink: add pcs_enable()/pcs_disable() methods Russell King (Oracle)
2022-06-13 13:00 ` [PATCH net-next 06/15] net: phylink: add pcs_pre_config()/pcs_post_config() methods Russell King (Oracle)
2022-06-14 18:41 ` Andrew Lunn
2022-06-13 13:00 ` [PATCH net-next 07/15] net: mdio: add unlocked mdiobus and mdiodev bus accessors Russell King (Oracle)
2022-06-14 21:44 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 08/15] net: dsa: add support for mac_prepare() and mac_finish() calls Russell King (Oracle)
2022-06-14 21:45 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 09/15] net: dsa: mv88e6xxx: move link forcing to mac_prepare/mac_finish Russell King (Oracle)
2022-06-14 21:47 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 10/15] net: dsa: mv88e6xxx: add infrastructure for phylink_pcs Russell King (Oracle)
2022-06-14 21:49 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 11/15] net: dsa: mv88e6xxx: export mv88e6xxx_pcs_decode_state() Russell King (Oracle)
2022-06-14 21:50 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 12/15] net: dsa: mv88e6xxx: convert 88e6185 to phylink_pcs Russell King (Oracle)
2022-06-14 21:53 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 13/15] net: dsa: mv88e6xxx: convert 88e6352 " Russell King
2022-06-14 21:57 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 14/15] net: dsa: mv88e6xxx: convert 88e639x " Russell King (Oracle)
2022-06-14 22:03 ` Andrew Lunn
2022-06-13 13:01 ` [PATCH net-next 15/15] net: dsa: mv88e6xxx: cleanup after phylink_pcs conversion Russell King (Oracle)
2022-06-14 22:03 ` Andrew Lunn
2022-06-13 21:29 ` [PATCH net-next 00/15] net: dsa: mv88e6xxx: convert to phylink pcs Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqmVdj4X5101PC1u@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kabel@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robert.hancock@calian$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox