Subject: Re: [Patch net-next v14 10/13] net: dsa: microchip: lan937x: add phylink_get_caps support

From: "Russell King (Oracle)" <[email-masked]>
Date: Thu, 30 Jun 2022 12:36:25 +0100

On Thu, Jun 30, 2022 at 03:50:38PM +0530, Arun Ramadoss wrote:
> The internal phy of the LAN937x are capable of 100Mbps speed. And the

Good English grammar suggests never to start a sentence with "And".

> xMII port of switch is capable of 10/100/1000Mbps.

... and supports flow control?

> +void lan937x_phylink_get_caps(struct ksz_device *dev, int port,
> +			      struct phylink_config *config)
> +{
> +	config->mac_capabilities = MAC_100FD;
> +
> +	if (dev->info->supports_rgmii[port]) {
> +		/* MII/RMII/RGMII ports */
> +		config->mac_capabilities |= MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
> +					    MAC_100HD | MAC_10 | MAC_1000FD;

And SGMII too? (Which seems to be a given because from your list in the
series cover message, SGMII ports also support RGMII).

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!