From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: Hauke Mehrtens <hauke@hauke-m•de>
Cc: "Florian Fainelli" <f.fainelli@gmail•com>,
"Vladimir Oltean" <olteanv@gmail•com>,
"Andrew Lunn" <andrew@lunn•ch>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"Alvin Šipraga" <alsi@bang-olufsen•dk>,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"David S. Miller" <davem@davemloft•net>,
"DENG Qingfang" <dqfext@gmail•com>,
"Eric Dumazet" <edumazet@google•com>,
"George McCollister" <george.mccollister@gmail•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org,
"Matthias Brugger" <matthias.bgg@gmail•com>,
netdev@vger•kernel.org, "Paolo Abeni" <pabeni@redhat•com>,
"Sean Wang" <sean.wang@mediatek•com>,
UNGLinuxDriver@microchip•com,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Woojung Huh" <woojung.huh@microchip•com>
Subject: Re: [PATCH RFC net-next v2 0/5] net: dsa: always use phylink
Date: Wed, 6 Jul 2022 21:24:51 +0100 [thread overview]
Message-ID: <YsXvk/GlFtswFyvk@shell.armlinux.org.uk> (raw)
In-Reply-To: <4ec0461c-0000-ff8c-4368-5d68d70b894e@hauke-m.de>
On Wed, Jul 06, 2022 at 09:05:22PM +0200, Hauke Mehrtens wrote:
> On 7/6/22 18:27, Florian Fainelli wrote:
> > On 7/6/22 03:14, Vladimir Oltean wrote:
> > > Hi Florian,
> > >
> > > On Tue, Jul 05, 2022 at 09:42:33AM -0700, Florian Fainelli wrote:
> > > > On 7/5/22 02:46, Russell King (Oracle) wrote:
> > > > > A new revision of the series which incorporates changes that Marek
> > > > > suggested. Specifically, the changes are:
> > > > >
> > > > > 1. Patch 2 - use the phylink_get_caps method in mv88e6xxx to get the
> > > > > default interface rather than re-using port_max_speed_mode()
> > > > >
> > > > > 2. Patch 4 - if no default interface is provided, use the supported
> > > > > interface mask to search for the first interface that gives the
> > > > > fastest speed.
> > > > >
> > > > > 3. Patch 5 - now also removes the port_max_speed_mode() method
> > > >
> > > > This was tested with bcm_sf2.c and b53_srab.b and did not cause
> > > > regressions,
> > > > however we do have a 'fixed-link' property for the CPU port
> > > > (always have had
> > > > one), so there was no regression expected.
> > >
> > > What about arch/arm/boot/dts/bcm47189-tenda-ac9.dts?
> >
> > You found one of the devices that I do not have access to and did not
> > test, thanks. We do expect to run the port at 2GBits/sec on these
> > devices however there is no "official" way to advertise that a port can
> > run at 2Gbits/sec, as this is not even a "sanctioned" speed. I do have a
> > similar device however, so let me run some more tests, we won't see a
> > regression however since we do not use the NATP accelerator which would
> > be the reason to run the port at 2Gbits/sec.
>
> I will try this change on some devices with the lantiq gswip driver at the
> weekend.
>
> On the SoC supported by the lantiq gswip driver the switch is integrated in
> the SoC and there is a internal link with more than 1GBit/s connecting the
> switch to the rest of the system. I think it is also around 2GBit/s. We can
> not configure the interface speed or many other interface settings for the
> link between the switch and the CPU. How should the device tree ideally look
> for this setup?
I think this falls into Andrew's "don't specify anything" category,
which means that we should default to the maximum speed for the
port - which is in this case quite clearly fixed at whatever the
internal link actually is.
From the get_caps() function, the fastest speed apparently supported is
1Gbps. I'm guessing the CPU port is one of ports 2..5 on xrx200 and
1..5 on xrx300 - in which case, PHY_INTERFACE_MODE_INTERNAL is likely
to be selected, which seems appropriate given what you've said above.
(PHY_INTERFACE_MODE_INTERNAL will be the first interface type found
that will give the highest speed as it permits any speed given in the
mac_capabilities.)
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-07-06 20:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 9:46 [PATCH RFC net-next v2 0/5] net: dsa: always use phylink Russell King (Oracle)
2022-07-05 9:47 ` [PATCH RFC net-next 1/5] net: dsa: add support for retrieving the interface mode Russell King (Oracle)
2022-07-05 9:47 ` [PATCH RFC net-next 2/5] net: dsa: mv88e6xxx: report the default interface mode for the port Russell King (Oracle)
2022-07-05 10:55 ` Marek Behún
2022-07-05 9:47 ` [PATCH RFC net-next 3/5] net: phylink: split out interface to caps translation Russell King (Oracle)
2022-07-05 9:48 ` [PATCH RFC net-next 4/5] net: phylink: add phylink_set_max_fixed_link() Russell King (Oracle)
2022-07-05 10:58 ` Marek Behún
2022-07-05 9:48 ` [PATCH RFC net-next 5/5] net: dsa: always use phylink for CPU and DSA ports Russell King (Oracle)
2022-07-06 10:26 ` Vladimir Oltean
2022-07-06 16:24 ` Russell King (Oracle)
2022-07-07 10:09 ` Russell King (Oracle)
2022-07-07 15:27 ` Vladimir Oltean
2022-07-07 15:48 ` Russell King (Oracle)
2022-07-07 16:38 ` Vladimir Oltean
2022-07-07 17:15 ` Russell King (Oracle)
2022-07-07 19:37 ` Vladimir Oltean
2022-07-07 20:23 ` Russell King (Oracle)
2022-07-07 21:48 ` Vladimir Oltean
2022-07-08 15:25 ` Russell King (Oracle)
2022-07-08 15:40 ` Marek Behún
2022-07-07 11:00 ` Russell King (Oracle)
2022-07-07 15:43 ` Vladimir Oltean
2022-07-07 16:32 ` Russell King (Oracle)
2022-07-07 16:50 ` Vladimir Oltean
2022-07-05 16:42 ` [PATCH RFC net-next v2 0/5] net: dsa: always use phylink Florian Fainelli
2022-07-06 10:14 ` Vladimir Oltean
2022-07-06 16:27 ` Florian Fainelli
2022-07-06 19:05 ` Hauke Mehrtens
2022-07-06 20:24 ` Russell King (Oracle) [this message]
2022-07-06 17:22 ` Kurt Kanzenbach
2022-07-06 22:46 ` Linus Walleij
2022-07-07 13:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsXvk/GlFtswFyvk@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=andrew@lunn$(echo .)ch \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=george.mccollister@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=hkallweit1@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox