From: Andrew Lunn <andrew@lunn•ch>
To: Wei Fang <wei.fang@nxp•com>
Cc: davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, robh+dt@kernel•org,
krzysztof.kozlowski+dt@linaro•org, shawnguo@kernel•org,
s.hauer@pengutronix•de, netdev@vger•kernel.org,
devicetree@vger•kernel.org, linux-kernel@vger•kernel.org,
kernel@pengutronix•de, festevam@gmail•com, linux-imx@nxp•com,
peng.fan@nxp•com, ping.bai@nxp•com, sudeep.holla@arm•com,
linux-arm-kernel@lists•infradead.org, aisheng.dong@nxp•com
Subject: Re: [PATCH V2 3/3] arm64: dts: imx8ulp-evk: Add the fec support
Date: Mon, 11 Jul 2022 09:02:15 +0200 [thread overview]
Message-ID: <YsvK99Gb0JL3YbQB@lunn.ch> (raw)
In-Reply-To: <20220711094434.369377-4-wei.fang@nxp.com>
On Mon, Jul 11, 2022 at 07:44:34PM +1000, Wei Fang wrote:
> Enable the fec on i.MX8ULP EVK board.
>
> Signed-off-by: Wei Fang <wei.fang@nxp•com>
> ---
> V2 change:
> Add clock_ext_rmii and clock_ext_ts. They are both related to EVK board.
> ---
> arch/arm64/boot/dts/freescale/imx8ulp-evk.dts | 57 +++++++++++++++++++
> 1 file changed, 57 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> index 33e84c4e9ed8..ebce716b10e6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp-evk.dts
> @@ -19,6 +19,21 @@ memory@80000000 {
> device_type = "memory";
> reg = <0x0 0x80000000 0 0x80000000>;
> };
> +
> + clock_ext_rmii: clock-ext-rmii {
> + compatible = "fixed-clock";
> + clock-frequency = <50000000>;
> + clock-output-names = "ext_rmii_clk";
> + #clock-cells = <0>;
> + };
> +
> + clock_ext_ts: clock-ext-ts {
> + compatible = "fixed-clock";
> + /* External ts clock is 50MHZ from PHY on EVK board. */
> + clock-frequency = <50000000>;
> + clock-output-names = "ext_ts_clk";
> + #clock-cells = <0>;
> + };
Do you need any PHY properties to turn this clock on? Or is it
strapped to be always on?
I'm surprised it is limited to Fast Ethernet. I know the Vybrid and
some of the older SoCs are Fast Ethernet only, but i thought all the
newer supported 1G?
Andrew
next prev parent reply other threads:[~2022-07-11 7:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 9:44 [PATCH V2 0/3] Add the fec node on i.MX8ULP platform Wei Fang
2022-07-11 9:44 ` [PATCH V2 1/3] dt-bindings: net: fsl,fec: Add i.MX8ULP FEC items Wei Fang
2022-07-11 11:10 ` Krzysztof Kozlowski
2022-07-11 9:44 ` [PATCH V2 2/3] arm64: dts: imx8ulp: Add the fec support Wei Fang
2022-07-11 9:44 ` [PATCH V2 3/3] arm64: dts: imx8ulp-evk: " Wei Fang
2022-07-11 7:02 ` Andrew Lunn [this message]
2022-07-11 8:01 ` [EXT] " Wei Fang
2022-07-14 2:46 ` [PATCH V2 0/3] Add the fec node on i.MX8ULP platform Jakub Kicinski
2022-07-14 2:57 ` [EXT] " Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YsvK99Gb0JL3YbQB@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=aisheng.dong@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=peng.fan@nxp$(echo .)com \
--cc=ping.bai@nxp$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=sudeep.holla@arm$(echo .)com \
--cc=wei.fang@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox