From: Andrew Lunn <andrew@lunn•ch>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro•org>
Cc: alexandru.tachici@analog•com, netdev@vger•kernel.org,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
devicetree@vger•kernel.org, krzysztof.kozlowski+dt@linaro•org,
gerhard@engleder-embedded•com, geert+renesas@glider•be,
joel@jms•id.au, stefan.wahren@i2se•com, wellslutw@gmail•com,
geert@linux-m68k•org, robh+dt@kernel•org,
d.michailidis@fungible•com, stephen@networkplumber•org,
l.stelmach@samsung•com, linux-kernel@vger•kernel.org
Subject: Re: [net-next v2 3/3] dt-bindings: net: adin1110: Add docs
Date: Mon, 25 Jul 2022 21:52:10 +0200 [thread overview]
Message-ID: <Yt70avEl443NkbJq@lunn.ch> (raw)
In-Reply-To: <a7d0f6c7-1943-8bef-71ff-736455609cde@linaro.org>
> You had phy nodes here, but they were not replaced with the phy-handle.
> No ethernet-ports or mdios with phy?
Since this is integrated silicon, much of that is not required. There
is a fixed relationship between the MAC and the PHY, so phy-handle is
pointless. There is no need to describe the MDIO bus, because nothing
can change. phy-mode is pointless, since it can only be internal.
ethernet-ports might be useful, if you want to use two different MAC
addresses. However, with Ethernet switches, you generally use the same
MAC address on all ports.
So i don't see a need for any of these properties.
Andrew
next prev parent reply other threads:[~2022-07-25 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 16:53 [net-next v2 0/3] net: ethernet: adi: Add ADIN1110 support alexandru.tachici
2022-07-25 16:53 ` [net-next v2 1/3] net: phy: adin1100: add PHY IDs of adin1110/adin2111 alexandru.tachici
2022-07-25 16:53 ` [net-next v2 2/3] net: ethernet: adi: Add ADIN1110 support alexandru.tachici
2022-07-25 20:17 ` Andrew Lunn
2022-07-27 13:26 ` [net-next,v2,2/3] " alexandru.tachici
2022-07-27 13:26 ` Andrew Lunn
2022-07-26 7:27 ` [net-next v2 2/3] " kernel test robot
2022-07-26 21:55 ` Andrew Lunn
2022-07-25 16:53 ` [net-next v2 3/3] dt-bindings: net: adin1110: Add docs alexandru.tachici
2022-07-25 19:37 ` Krzysztof Kozlowski
2022-07-25 19:52 ` Andrew Lunn [this message]
2022-07-25 20:23 ` Krzysztof Kozlowski
2022-07-25 19:50 ` Rob Herring
2022-07-25 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt70avEl443NkbJq@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=alexandru.tachici@analog$(echo .)com \
--cc=d.michailidis@fungible$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=geert@linux-m68k$(echo .)org \
--cc=gerhard@engleder-embedded$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=krzysztof.kozlowski@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=l.stelmach@samsung$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=robh+dt@kernel$(echo .)org \
--cc=stefan.wahren@i2se$(echo .)com \
--cc=stephen@networkplumber$(echo .)org \
--cc=wellslutw@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox