Subject: Re: [for-next][PATCH 03/23] tracing: devlink: Use static array for string in devlink_trap_report even

From: Ido Schimmel <[email-masked]>
Date: Thu, 14 Jul 2022 21:40:40 +0300

On Thu, Jul 14, 2022 at 12:42:59PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (Google)" <[email-masked]>
> 
> The trace event devlink_trap_report uses the __dynamic_array() macro to
> determine the size of the input_dev_name field. This is because it needs
> to test the dev field for NULL, and will use "NULL" if it is. But it also
> has the size of the dynamic array as a fixed IFNAMSIZ bytes. This defeats
> the purpose of the dynamic array, as this will reserve that amount of
> bytes on the ring buffer, and to make matters worse, it will even save
> that size in the event as the event expects it to be dynamic (for which it
> is not).
> 
> Since IFNAMSIZ is just 16 bytes, just make it a static array and this will
> remove the meta data from the event that records the size.
> 
> Link: https://lkml.kernel.org/r/[email-masked]
> 
> Cc: Leon Romanovsky <[email-masked]>
> Cc: Jiri Pirko <[email-masked]>
> Cc: "David S. Miller" <[email-masked]>
> Cc: Eric Dumazet <[email-masked]>
> Cc: Paolo Abeni <[email-masked]>
> Cc: [email-masked]
> Acked-by: Jakub Kicinski <[email-masked]>
> Signed-off-by: Steven Rostedt (Google) <[email-masked]>

On the off chance that my tags weren't omitted on purpose:

Reviewed-by: Ido Schimmel <[email-masked]>
Tested-by: Ido Schimmel <[email-masked]>

s/even/event/ in subject