Subject: Re: [PATCH bpf-next v6 12/23] HID: initial BPF implementation

From: Greg KH <[email-masked]>
Date: Fri, 15 Jul 2022 07:02:44 +0200

On Tue, Jul 12, 2022 at 04:58:39PM +0200, Benjamin Tissoires wrote:
> --- /dev/null
> +++ b/drivers/hid/bpf/Kconfig
> @@ -0,0 +1,19 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +menu "HID-BPF support"
> +	#depends on x86_64
> +
> +config HID_BPF
> +	bool "HID-BPF support"
> +	default y

Things are only default y if you can't boot your machine without it.
Perhaps just mirror what HID is to start with and do not select HID?

> +	depends on BPF && BPF_SYSCALL
> +	select HID

select is rough, why not depend?

thanks,

greg k-