From: Andrew Lunn <andrew@lunn•ch>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: netdev@vger•kernel.org, "David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Vivien Didelot" <vivien.didelot@gmail•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Oleksij Rempel" <linux@rempel-privat•de>,
"Christian Marangi" <ansuelsmth@gmail•com>,
"John Crispin" <john@phrozen•org>,
"Kurt Kanzenbach" <kurt@linutronix•de>,
"Mans Rullgard" <mans@mansr•com>,
"Arun Ramadoss" <arun.ramadoss@microchip•com>,
"Woojung Huh" <woojung.huh@microchip•com>,
UNGLinuxDriver@microchip•com,
"Claudiu Manoil" <claudiu.manoil@nxp•com>,
"Alexandre Belloni" <alexandre.belloni@bootlin•com>,
"George McCollister" <george.mccollister@gmail•com>,
"DENG Qingfang" <dqfext@gmail•com>,
"Sean Wang" <sean.wang@mediatek•com>,
"Landen Chao" <Landen.Chao@mediatek•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"Hauke Mehrtens" <hauke@hauke-m•de>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail•com>,
"Aleksander Jan Bajkowski" <olek2@wp•pl>,
"Alvin Šipraga" <alsi@bang-olufsen•dk>,
"Luiz Angelo Daros de Luca" <luizluca@gmail•com>,
"Linus Walleij" <linus.walleij@linaro•org>,
"Pawel Dembicki" <paweldembicki@gmail•com>,
"Clément Léger" <clement.leger@bootlin•com>,
"Geert Uytterhoeven" <geert+renesas@glider•be>,
"Russell King" <rmk+kernel@armlinux•org.uk>
Subject: Re: [PATCH net-next] net: dsa: validate that DT nodes of shared ports have the properties they need
Date: Sat, 23 Jul 2022 20:09:34 +0200 [thread overview]
Message-ID: <Ytw5XrDYa4FQF+Uk@lunn.ch> (raw)
In-Reply-To: <20220723164635.1621911-1-vladimir.oltean@nxp.com>
Hi Vladimir
I think this is a first good step.
> +static const char * const dsa_switches_skipping_validation[] = {
One thing to consider is do we want to go one step further and make
this dsa_switches_dont_enforce_validation
Meaning always run the validation, and report what is not valid, but
don't enforce with an -EINVAL for switches on the list?
Maybe it is too early for that, we first need to submit patches to the
mainline DT files to fixes those we can?
Looking at the mv88e6xxx instances, adding fixed-links should not be
too hard. What might be harder is the phy-mode, in particular, what
RGMII delay should be specified.
Andrew
next prev parent reply other threads:[~2022-07-23 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 16:46 [PATCH net-next] net: dsa: validate that DT nodes of shared ports have the properties they need Vladimir Oltean
2022-07-23 18:09 ` Andrew Lunn [this message]
2022-07-24 14:21 ` Vladimir Oltean
2022-07-24 14:39 ` Andrew Lunn
2022-07-24 16:59 ` Florian Fainelli
2022-07-24 20:28 ` Vladimir Oltean
2022-07-25 16:37 ` Florian Fainelli
2022-07-23 21:50 ` kernel test robot
2022-07-24 0:30 ` Alvin Šipraga
2022-07-25 16:27 ` Florian Fainelli
2022-07-25 19:21 ` Martin Blumenstingl
2022-07-26 7:12 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ytw5XrDYa4FQF+Uk@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=alsi@bang-olufsen$(echo .)dk \
--cc=ansuelsmth@gmail$(echo .)com \
--cc=arun.ramadoss@microchip$(echo .)com \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=clement.leger@bootlin$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dqfext@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=geert+renesas@glider$(echo .)be \
--cc=george.mccollister@gmail$(echo .)com \
--cc=hauke@hauke-m$(echo .)de \
--cc=john@phrozen$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kurt@linutronix$(echo .)de \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux@rempel-privat$(echo .)de \
--cc=luizluca@gmail$(echo .)com \
--cc=mans@mansr$(echo .)com \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olek2@wp$(echo .)pl \
--cc=pabeni@redhat$(echo .)com \
--cc=paweldembicki@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=sean.wang@mediatek$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
--cc=woojung.huh@microchip$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox