public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Colin Foster <colin.foster@in-advantage•com>
To: linux-arm-kernel@lists•infradead.org, linux-gpio@vger•kernel.org,
	netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
	devicetree@vger•kernel.org
Cc: Terry Bowman <terry.bowman@amd•com>,
	Vladimir Oltean <vladimir.oltean@nxp•com>,
	Wolfram Sang <wsa@kernel•org>,
	Andy Shevchenko <andy.shevchenko@gmail•com>,
	UNGLinuxDriver@microchip•com,
	Steen Hegelund <Steen.Hegelund@microchip•com>,
	Lars Povlsen <lars.povlsen@microchip•com>,
	Linus Walleij <linus.walleij@linaro•org>,
	Paolo Abeni <pabeni@redhat•com>, Jakub Kicinski <kuba@kernel•org>,
	Eric Dumazet <edumazet@google•com>,
	"David S. Miller" <davem@davemloft•net>,
	Russell King <linux@armlinux•org.uk>,
	Heiner Kallweit <hkallweit1@gmail•com>,
	Andrew Lunn <andrew@lunn•ch>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
	Rob Herring <robh+dt@kernel•org>,
	Lee Jones <lee.jones@linaro•org>,
	katie.morris@in-advantage•com
Subject: Re: [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi
Date: Fri, 5 Aug 2022 10:44:16 -0700	[thread overview]
Message-ID: <Yu1W8DMaP8xlyyr5@euler> (raw)
In-Reply-To: <20220803054728.1541104-10-colin.foster@in-advantage.com>

As I'm going through Andy's suggestions, I came across a couple more
include changes / misses:

On Tue, Aug 02, 2022 at 10:47:28PM -0700, Colin Foster wrote:

...

> diff --git a/drivers/mfd/ocelot-core.c b/drivers/mfd/ocelot-core.c

...

> +
> +int ocelot_chip_reset(struct device *dev)

#include <linux/device.h>

> +{
> +	struct ocelot_ddata *ddata = dev_get_drvdata(dev);
> +	int ret, val;
> +
> +	/*
> +	 * Reset the entire chip here to put it into a completely known state.
> +	 * Other drivers may want to reset their own subsystems. The register
> +	 * self-clears, so one write is all that is needed and wait for it to
> +	 * clear.
> +	 */
> +	ret = regmap_write(ddata->gcb_regmap, REG_GCB_SOFT_RST, BIT_SOFT_CHIP_RST);
> +	if (ret)
> +		return ret;
> +
> +	return readx_poll_timeout(ocelot_gcb_chip_rst_status, ddata, val, !val,
> +				  VSC7512_GCB_RST_SLEEP_US, VSC7512_GCB_RST_TIMEOUT_US);

#include <linux/iopoll.h>

> +}
> +EXPORT_SYMBOL_NS(ocelot_chip_reset, MFD_OCELOT);

#include <linux/export.h>

> +
> +static const struct resource vsc7512_miim0_resources[] = {
> +	DEFINE_RES_REG_NAMED(VSC7512_MIIM0_RES_START, VSC7512_MIIM_RES_SIZE, "gcb_miim0"),
> +	DEFINE_RES_REG_NAMED(VSC7512_PHY_RES_START, VSC7512_PHY_RES_SIZE, "gcb_phy"),
> +};

#include <linux/ioport.h>

...

> +++ b/drivers/mfd/ocelot-spi.c

...

> +#include <linux/kconfig.h>

Not needed here - handled entirely in drivers/mfd/ocelot.h now.

...

> +
> +static int ocelot_spi_initialize(struct device *dev)

#include <linux/device.h>

> +{
> +	struct ocelot_ddata *ddata = dev_get_drvdata(dev);
> +	u32 val, check;

#include <linux/types.h>

...

> +
> +	if (check != val)
> +		return -ENODEV;

#include <linux/errno.h>

> +
> +	return 0;
> +}

...

> +
> +struct regmap *ocelot_spi_init_regmap(struct device *dev, const struct resource *res)
> +{
> +	struct regmap_config regmap_config;
> +
> +	memcpy(&regmap_config, &ocelot_spi_regmap_config, sizeof(regmap_config));
> +
> +	regmap_config.name = res->name;
> +	regmap_config.max_register = res->end - res->start;
> +	regmap_config.reg_base = res->start;
> +
> +	return devm_regmap_init(dev, &ocelot_spi_regmap_bus, dev, &regmap_config);
> +}
> +EXPORT_SYMBOL_NS(ocelot_spi_init_regmap, MFD_OCELOT_SPI);

#include <linux/export.h>

...

> +
> +	r = ocelot_spi_init_regmap(dev, &vsc7512_dev_cpuorg_resource);
> +	if (IS_ERR(r))
> +		return PTR_ERR(r);

#include <linux/err.h>

...

> +
> +static const struct spi_device_id ocelot_spi_ids[] = {

#include <linux/mod_devicetable.h>

> +	{ "vsc7512", 0 },
> +	{ }
> +};
> +
> +static const struct of_device_id ocelot_spi_of_match[] = {
> +	{ .compatible = "mscc,vsc7512" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, ocelot_spi_of_match);

  parent reply	other threads:[~2022-08-05 17:45 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03  5:47 [PATCH v15 mfd 0/9] add support for VSC7512 control over SPI Colin Foster
2022-08-03  5:47 ` [PATCH v15 mfd 1/9] mfd: ocelot: add helper to get regmap from a resource Colin Foster
2022-08-03 11:31   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 2/9] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:31   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 3/9] pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module Colin Foster
2022-08-03 11:32   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 4/9] pinctrl: ocelot: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:32   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 5/9] pinctrl: microchip-sgpio: allow sgpio driver to be used as a module Colin Foster
2022-08-03 11:32   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 6/9] pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration Colin Foster
2022-08-03 11:32   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 7/9] resource: add define macro for register address resources Colin Foster
2022-08-03 11:33   ` Andy Shevchenko
2022-08-03  5:47 ` [PATCH v15 mfd 8/9] dt-bindings: mfd: ocelot: add bindings for VSC7512 Colin Foster
2022-08-03  5:47 ` [PATCH v15 mfd 9/9] mfd: ocelot: add support for the vsc7512 chip via spi Colin Foster
2022-08-03 11:45   ` Andy Shevchenko
2022-08-03 15:56     ` Colin Foster
2022-08-03 17:10       ` Andy Shevchenko
2022-08-03 17:31         ` Colin Foster
2022-08-05 17:44   ` Colin Foster [this message]
2022-08-05 17:58     ` Andy Shevchenko
2022-08-05 18:07       ` Colin Foster
2022-08-05 18:14         ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yu1W8DMaP8xlyyr5@euler \
    --to=colin.foster@in-advantage$(echo .)com \
    --cc=Steen.Hegelund@microchip$(echo .)com \
    --cc=UNGLinuxDriver@microchip$(echo .)com \
    --cc=andrew@lunn$(echo .)ch \
    --cc=andy.shevchenko@gmail$(echo .)com \
    --cc=davem@davemloft$(echo .)net \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=edumazet@google$(echo .)com \
    --cc=hkallweit1@gmail$(echo .)com \
    --cc=katie.morris@in-advantage$(echo .)com \
    --cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
    --cc=kuba@kernel$(echo .)org \
    --cc=lars.povlsen@microchip$(echo .)com \
    --cc=lee.jones@linaro$(echo .)org \
    --cc=linus.walleij@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-gpio@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=robh+dt@kernel$(echo .)org \
    --cc=terry.bowman@amd$(echo .)com \
    --cc=vladimir.oltean@nxp$(echo .)com \
    --cc=wsa@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox