From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Marcin Wojtas <mw@semihalf•com>
Cc: linux-kernel@vger•kernel.org, linux-acpi@vger•kernel.org,
netdev@vger•kernel.org, rafael@kernel•org,
sean.wang@mediatek•com, Landen.Chao@mediatek•com,
linus.walleij@linaro•org, andrew@lunn•ch,
vivien.didelot@gmail•com, f.fainelli@gmail•com,
olteanv@gmail•com, davem@davemloft•net, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, linux@armlinux•org.uk,
hkallweit1@gmail•com, gjb@semihalf•com, jaz@semihalf•com,
tn@semihalf•com, Samer.El-Haj-Mahmoud@arm•com,
upstream@semihalf•com
Subject: Re: [net-next: PATCH v3 8/8] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs
Date: Wed, 27 Jul 2022 16:37:18 +0300 [thread overview]
Message-ID: <YuE/jsHMgDcKKEff@smile.fi.intel.com> (raw)
In-Reply-To: <20220727064321.2953971-9-mw@semihalf.com>
On Wed, Jul 27, 2022 at 08:43:21AM +0200, Marcin Wojtas wrote:
> In order to support both DT and ACPI in future, modify the
> mv88e6xx driver code to use device_/fwnode_ equivalent routines.
> No functional change is introduced by this patch.
...
> static int mv88e6xxx_probe(struct mdio_device *mdiodev)
> {
> struct dsa_mv88e6xxx_pdata *pdata = mdiodev->dev.platform_data;
> + struct fwnode_handle *fwnode = dev_fwnode(&mdiodev->dev);
Move this...
> const struct mv88e6xxx_info *compat_info = NULL;
> struct device *dev = &mdiodev->dev;
> - struct device_node *np = dev->of_node;
...here as
struct fwnode_handle *fwnode = dev_fwnode(dev);
> struct mv88e6xxx_chip *chip;
> int port;
> int err;
> + if (fwnode)
Redundant check.
> + compat_info = device_get_match_data(dev);
> + else if (pdata) {
> compat_info = pdata_device_get_match_data(dev);
compat_info - device_get_match_data(dev);
if (!compat_info && pdata)
compat_info = pdata_device_get_match_data(dev);
...
> + if (fwnode)
> + device_property_read_u32(dev, "eeprom-length",
> + &chip->eeprom_len);
> else
> chip->eeprom_len = pdata->eeprom_len;
Can be done w/o conditional
chip->eeprom_len = pdata->eeprom_len;
device_property_read_u32(dev, "eeprom-length", &chip->eeprom_len);
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-07-27 13:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 6:43 [net-next: PATCH v3 0/8] DSA: switch to fwnode_/device_ Marcin Wojtas
2022-07-27 6:43 ` [net-next: PATCH v3 1/8] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-07-27 10:24 ` Andy Shevchenko
2022-07-27 6:43 ` [net-next: PATCH v3 2/8] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-07-27 10:28 ` Andy Shevchenko
2022-07-27 6:43 ` [net-next: PATCH v3 3/8] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-07-27 11:29 ` Andy Shevchenko
2022-07-27 6:43 ` [net-next: PATCH v3 4/8] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-07-27 6:43 ` [net-next: PATCH v3 5/8] device property: introduce fwnode_find_parent_dev_match Marcin Wojtas
2022-07-27 11:33 ` Andy Shevchenko
2022-07-27 6:43 ` [net-next: PATCH v3 6/8] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-07-27 14:31 ` Vladimir Oltean
2022-07-27 15:18 ` Marcin Wojtas
2022-07-27 16:38 ` Vladimir Oltean
2022-07-27 17:40 ` Marcin Wojtas
2022-07-27 21:11 ` Vladimir Oltean
2022-07-27 21:27 ` Vladimir Oltean
2022-07-28 6:47 ` Marcin Wojtas
2022-07-28 19:56 ` Vladimir Oltean
2022-07-28 20:18 ` Andrew Lunn
2022-07-28 21:23 ` Marcin Wojtas
2022-07-28 22:20 ` Andrew Lunn
2022-07-29 9:59 ` Andy Shevchenko
[not found] ` <CAHp75VfGfKx1fggoE7wf4ndmUv4FEVfV=-EaO0ypescmNqDFkw@mail.gmail.com>
2022-07-28 6:52 ` Marcin Wojtas
2022-07-28 9:16 ` Vladimir Oltean
2022-07-28 16:56 ` Marcin Wojtas
2022-07-28 19:16 ` Vladimir Oltean
2022-07-28 19:49 ` Marcin Wojtas
2022-07-27 17:00 ` Andy Shevchenko
2022-07-27 17:41 ` Marcin Wojtas
2022-07-27 6:43 ` [net-next: PATCH v3 7/8] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-07-27 13:32 ` Andy Shevchenko
2022-07-27 6:43 ` [net-next: PATCH v3 8/8] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
2022-07-27 13:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuE/jsHMgDcKKEff@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=Landen.Chao@mediatek$(echo .)com \
--cc=Samer.El-Haj-Mahmoud@arm$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=gjb@semihalf$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=jaz@semihalf$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-acpi@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=mw@semihalf$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=rafael@kernel$(echo .)org \
--cc=sean.wang@mediatek$(echo .)com \
--cc=tn@semihalf$(echo .)com \
--cc=upstream@semihalf$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox