From: Colin Foster <colin.foster@in-advantage•com>
To: Vladimir Oltean <vladimir.oltean@nxp•com>
Cc: Jakub Kicinski <kuba@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Florian Fainelli <f.fainelli@gmail•com>,
Vivien Didelot <vivien.didelot@gmail•com>,
Andrew Lunn <andrew@lunn•ch>, Vladimir Oltean <olteanv@gmail•com>,
Claudiu Manoil <claudiu.manoil@nxp•com>,
Alexandre Belloni <alexandre.belloni@bootlin•com>,
"UNGLinuxDriver@microchip•com" <UNGLinuxDriver@microchip•com>,
Roopa Prabhu <roopa@nvidia•com>,
Nikolay Aleksandrov <razor@blackwall•org>
Subject: Re: [PATCH v2 net-next 8/9] net: mscc: ocelot: set up tag_8021q CPU ports independent of user port affinity
Date: Fri, 19 Aug 2022 06:45:48 -0700 [thread overview]
Message-ID: <Yv+UDHgfZ0krm9X+@euler> (raw)
In-Reply-To: <20220819133859.7qzpo7kn3eviymzo@skbuf>
On Fri, Aug 19, 2022 at 01:39:00PM +0000, Vladimir Oltean wrote:
> On Fri, Aug 19, 2022 at 06:37:56AM -0700, Colin Foster wrote:
> > On Fri, Aug 19, 2022 at 11:06:23AM +0000, Vladimir Oltean wrote:
> > > On Thu, Aug 18, 2022 at 08:58:56PM -0700, Jakub Kicinski wrote:
> > > > ERROR: modpost: "ocelot_port_teardown_dsa_8021q_cpu" [drivers/net/dsa/ocelot/mscc_felix.ko] undefined!
> > > > ERROR: modpost: "ocelot_port_teardown_dsa_8021q_cpu" [drivers/net/dsa/ocelot/mscc_seville.ko] undefined!
> > >
> > > Damn, I forgot EXPORT_SYMBOL_GPL()....
> > > Since I see you've marked the patches as changes requested already, I'll
> > > go ahead and resubmit.
> >
> > Any reason not to use the _NS() variants?
>
> What's _NS() and why would I use it?
include/linux/export.h.
I don't know when to use one over the other. I just know it was
requested in my MFD set for drivers/mfd/ocelot*. Partitioning of the
symtab, from what I best understand.
next prev parent reply other threads:[~2022-08-19 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:52 [PATCH v2 net-next 0/9] DSA changes for multiple CPU ports (part 3) Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 1/9] net: dsa: walk through all changeupper notifier functions Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 2/9] net: dsa: don't stop at NOTIFY_OK when calling ds->ops->port_prechangeupper Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 3/9] net: bridge: move DSA master bridging restriction to DSA Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 4/9] net: dsa: existing DSA masters cannot join upper interfaces Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 5/9] net: dsa: only bring down user ports assigned to a given DSA master Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 6/9] net: dsa: all DSA masters must be down when changing the tagging protocol Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 7/9] net: dsa: use dsa_tree_for_each_cpu_port in dsa_tree_{setup,teardown}_master Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 8/9] net: mscc: ocelot: set up tag_8021q CPU ports independent of user port affinity Vladimir Oltean
2022-08-19 3:58 ` Jakub Kicinski
2022-08-19 11:06 ` Vladimir Oltean
2022-08-19 13:37 ` Colin Foster
2022-08-19 13:39 ` Vladimir Oltean
2022-08-19 13:45 ` Colin Foster [this message]
2022-08-19 13:48 ` Vladimir Oltean
2022-08-19 13:57 ` Colin Foster
2022-08-19 16:44 ` Vladimir Oltean
2022-08-18 13:52 ` [PATCH v2 net-next 9/9] net: mscc: ocelot: adjust forwarding domain for CPU ports in a LAG Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yv+UDHgfZ0krm9X+@euler \
--to=colin.foster@in-advantage$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=alexandre.belloni@bootlin$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=claudiu.manoil@nxp$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=razor@blackwall$(echo .)org \
--cc=roopa@nvidia$(echo .)com \
--cc=vivien.didelot@gmail$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox