Subject: Re: [PATCH net] net: phylink: allow RGMII/RTBI in-band status

From: "Russell King (Oracle)" <[email-masked]>
Date: Tue, 23 Aug 2022 23:49:17 +0100

On Tue, Aug 23, 2022 at 03:26:25PM -0700, Jakub Kicinski wrote:
> On Fri, 19 Aug 2022 17:26:06 +0800 Qingfang DENG wrote:
> > As per RGMII specification v2.0, section 3.4.1, RGMII/RTBI has an
> > optional in-band status feature where the PHY's link status, speed and
> > duplex mode can be passed to the MAC.
> > Allow RGMII/RTBI to use in-band status.
> > 
> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> > Signed-off-by: Qingfang DENG <[email-masked]>
> 
> Russell, PHY folks, any judgment on this one?

It looks fine to me, thanks for the reminder.

Reviewed-by: Russell King (Oracle) <[email-masked]>

> Qingfang is there a platform which require RGMII to be supported 
> in upstream LTS branches? If there isn't you should re-target 
> the patch at net-next and drop the Fixes tag. Not implementing
> the entire spec is not considered a bug. Please clarify this
> in the commit message.

I agree - clarification is required.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!