From: Simon Horman <simon.horman@corigine•com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix•de>
Cc: netdev@vger•kernel.org, Jakub Kicinski <kuba@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
Thomas Gleixner <tglx@linutronix•de>,
Peter Zijlstra <peterz@infradead•org>,
Catherine Sullivan <csully@google•com>,
David Awogbemila <awogbemila@google•com>,
Dimitris Michailidis <dmichail@fungible•com>,
Eric Dumazet <edumazet@google•com>,
Hans Ulli Kroll <ulli.kroll@googlemail•com>,
Jeroen de Borst <jeroendb@google•com>,
Johannes Berg <johannes@sipsolutions•net>,
Linus Walleij <linus.walleij@linaro•org>,
Paolo Abeni <pabeni@redhat•com>,
linux-arm-kernel@lists•infradead.org,
linux-wireless@vger•kernel.org, oss-drivers@corigine•com,
stable@vger•kernel.org
Subject: Re: [PATCH net 2/2] net: Use u64_stats_fetch_begin_irq() for stats fetch.
Date: Mon, 29 Aug 2022 11:55:26 +0200 [thread overview]
Message-ID: <YwyNDi3p72DBvZ/3@corigine.com> (raw)
In-Reply-To: <20220825113645.212996-3-bigeasy@linutronix.de>
On Thu, Aug 25, 2022 at 01:36:45PM +0200, Sebastian Andrzej Siewior wrote:
> On 32bit-UP u64_stats_fetch_begin() disables only preemption. If the
> reader is in preemptible context and the writer side
> (u64_stats_update_begin*()) runs in an interrupt context (IRQ or
> softirq) then the writer can update the stats during the read operation.
> This update remains undetected.
>
> Use u64_stats_fetch_begin_irq() to ensure the stats fetch on 32bit-UP
> are not interrupted by a writer. 32bit-SMP remains unaffected by this
> change.
Thanks,
for the NFP driver portion:
Reviewed-by: Simon Horman <simon.horman@corigine•com>
next prev parent reply other threads:[~2022-08-29 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 11:36 [PATCH net 0/2] net: u64_stats fixups for 32bit Sebastian Andrzej Siewior
2022-08-25 11:36 ` [PATCH net 1/2] net: dsa: xrs700x: Use irqsave variant for u64 stats update Sebastian Andrzej Siewior
2022-08-25 11:51 ` George McCollister
2022-08-25 11:36 ` [PATCH net 2/2] net: Use u64_stats_fetch_begin_irq() for stats fetch Sebastian Andrzej Siewior
2022-08-29 9:55 ` Simon Horman [this message]
2022-08-29 12:10 ` [PATCH net 0/2] net: u64_stats fixups for 32bit patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwyNDi3p72DBvZ/3@corigine.com \
--to=simon.horman@corigine$(echo .)com \
--cc=awogbemila@google$(echo .)com \
--cc=bigeasy@linutronix$(echo .)de \
--cc=csully@google$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dmichail@fungible$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=jeroendb@google$(echo .)com \
--cc=johannes@sipsolutions$(echo .)net \
--cc=kuba@kernel$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oss-drivers@corigine$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=ulli.kroll@googlemail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox