From: "Russell King (Oracle)" <linux@armlinux•org.uk>
To: "Alvin Šipraga" <ALSI@bang-olufsen•dk>
Cc: Mark Kettenis <mark.kettenis@xs4all•nl>,
"aspriel@gmail•com" <aspriel@gmail•com>,
"franky.lin@broadcom•com" <franky.lin@broadcom•com>,
"hante.meuleman@broadcom•com" <hante.meuleman@broadcom•com>,
"alyssa@rosenzweig•io" <alyssa@rosenzweig•io>,
"asahi@lists•linux.dev" <asahi@lists•linux.dev>,
"brcm80211-dev-list.pdl@broadcom•com"
<brcm80211-dev-list.pdl@broadcom•com>,
"davem@davemloft•net" <davem@davemloft•net>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"edumazet@google•com" <edumazet@google•com>,
"marcan@marcan•st" <marcan@marcan•st>,
"kuba@kernel•org" <kuba@kernel•org>,
"kvalo@kernel•org" <kvalo@kernel•org>,
"krzysztof.kozlowski+dt@linaro•org"
<krzysztof.kozlowski+dt@linaro•org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"linux-wireless@vger•kernel.org" <linux-wireless@vger•kernel.org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"pabeni@redhat•com" <pabeni@redhat•com>,
"zajec5@gmail•com" <zajec5@gmail•com>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
"SHA-cyfmac-dev-list@infineon•com"
<SHA-cyfmac-dev-list@infineon•com>,
"sven@svenpeter•dev" <sven@svenpeter•dev>,
"arend@broadcom•com" <arend@broadcom•com>
Subject: Re: [PATCH wireless-next v2 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips
Date: Mon, 12 Sep 2022 15:29:07 +0100 [thread overview]
Message-ID: <Yx9CM210SorcM1nP@shell.armlinux.org.uk> (raw)
In-Reply-To: <20220912142727.tmqd7h7axwo226hm@bang-olufsen.dk>
On Mon, Sep 12, 2022 at 02:27:32PM +0000, Alvin Šipraga wrote:
> Hi both,
>
> On Mon, Sep 12, 2022 at 04:13:08PM +0200, Mark Kettenis wrote:
> > > Date: Mon, 12 Sep 2022 15:01:06 +0100
> > > From: "Russell King (Oracle)" <linux@armlinux•org.uk>
> > >
> > > On Mon, Sep 12, 2022 at 01:04:58PM +0100, Russell King (Oracle) wrote:
> > > > On Mon, Sep 12, 2022 at 11:59:17AM +0000, Alvin Šipraga wrote:
> > > > > On Mon, Sep 12, 2022 at 10:52:41AM +0100, Russell King wrote:
> > > > > > From: Hector Martin <marcan@marcan•st>
> > > > > >
> > > > > > This binding is currently used for SDIO devices, but these chips are
> > > > > > also used as PCIe devices on DT platforms and may be represented in the
> > > > > > DT. Re-use the existing binding and add chip compatibles used by Apple
> > > > > > T2 and M1 platforms (the T2 ones are not known to be used in DT
> > > > > > platforms, but we might as well document them).
> > > > > >
> > > > > > Then, add properties required for firmware selection and calibration on
> > > > > > M1 machines.
> > > > > >
> > > > > > Reviewed-by: Linus Walleij <linus.walleij@linaro•org>
> > > > > > Signed-off-by: Hector Martin <marcan@marcan•st>
> > > > > > Reviewed-by: Mark Kettenis <kettenis@openbsd•org>
> > > > > > Reviewed-by: Rob Herring <robh@kernel•org>
> > > > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux•org.uk>
> > > > > > ---
> > > > > > .../net/wireless/brcm,bcm4329-fmac.yaml | 39 +++++++++++++++++--
> > > > > > 1 file changed, 35 insertions(+), 4 deletions(-)
> > > > > >
> > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > > > > > index 53b4153d9bfc..fec1cc9b9a08 100644
> > > > > > --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > > > > > +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> > > > > > @@ -4,7 +4,7 @@
> > > > > > $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml
> > > > > > $schema: http://devicetree.org/meta-schemas/core.yaml
> > > > > >
> > > > > > -title: Broadcom BCM4329 family fullmac wireless SDIO devices
> > > > > > +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices
> > > > > >
> > > > > > maintainers:
> > > > > > - Arend van Spriel <arend@broadcom•com>
> > > > > > @@ -41,11 +41,17 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices
> > > > > > - cypress,cyw4373-fmac
> > > > > > - cypress,cyw43012-fmac
> > > > > > - const: brcm,bcm4329-fmac
> > > > > > - - const: brcm,bcm4329-fmac
> > > > > > + - enum:
> > > > > > + - brcm,bcm4329-fmac
> > > > > > + - pci14e4,43dc # BCM4355
> > > > > > + - pci14e4,4464 # BCM4364
> > > > > > + - pci14e4,4488 # BCM4377
> > > > > > + - pci14e4,4425 # BCM4378
> > > > > > + - pci14e4,4433 # BCM4387
> > > > > >
> > > > > > reg:
> > > > > > - description: SDIO function number for the device, for most cases
> > > > > > - this will be 1.
> > > > > > + description: SDIO function number for the device (for most cases
> > > > > > + this will be 1) or PCI device identifier.
> > > > > >
> > > > > > interrupts:
> > > > > > maxItems: 1
> > > > > > @@ -85,6 +91,31 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices
> > > > > > takes precedence.
> > > > > > type: boolean
> > > > > >
> > > > > > + brcm,cal-blob:
> > > > > > + $ref: /schemas/types.yaml#/definitions/uint8-array
> > > > > > + description: A per-device calibration blob for the Wi-Fi radio. This
> > > > > > + should be filled in by the bootloader from platform configuration
> > > > > > + data, if necessary, and will be uploaded to the device if present.
> > > > >
> > > > > Is this a leftover from a previous revision of the patchset? Because as
> > > > > far as I can tell, the CLM blob is (still) being loaded via firmware,
> > > > > and no additional parsing has been added for this particular OF
> > > > > property. Should it be dropped?
> > > >
> > > > It does appear to be unparsed, but I don't know whether it's needed for
> > > > the binding or not. I'll wait for the Asahi folk to review your comment
> > > > before possibly removing it.
> > >
> > > Okay, the answer is, it is still very much part of the binding, and
> > > the m1n1 boot loader populates it.
> > >
> > > This series is a subset of a larger series (remember the previous 34
> > > or 35 patch series?), so there are things in the binding document
> > > which are not included in this series.
> > >
> > > I don't think it makes sense to break up the binding document given
> > > that it has already been reviewed several times in its current state,
> > > should we really remove this one property and throw away all that
> > > review effort.
> >
> > The OpenBSD driver already uses these properties. So even if the
> > Linux driver doesn't use this yet, there is an existing implementation
> > that does. That should be good enough for it to be included in the
> > binding isn't it?
>
> Yes, I suspected that might be the case too. I think it's fine.
>
> Thanks Russel for the clarification btw. Feel free to add my
>
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen•dk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-09-12 14:29 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 9:52 [PATCH wireless-next v2 0/12] Add support for bcm4378 on Apple platforms Russell King (Oracle)
2022-09-12 9:52 ` [PATCH wireless-next v2 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Russell King
2022-09-12 11:59 ` Alvin Šipraga
2022-09-12 12:04 ` Russell King (Oracle)
2022-09-12 14:01 ` Russell King (Oracle)
2022-09-12 14:13 ` Mark Kettenis
2022-09-12 14:27 ` Alvin Šipraga
2022-09-12 14:29 ` Russell King (Oracle) [this message]
2022-09-12 9:52 ` [PATCH wireless-next v2 02/12] brcmfmac: firmware: Handle per-board clm_blob files Russell King
2022-09-15 15:33 ` Alvin Šipraga
2022-09-12 9:52 ` [PATCH wireless-next v2 03/12] brcmfmac: pcie/sdio/usb: Get CLM blob via standard firmware mechanism Russell King
2022-09-15 15:33 ` Alvin Šipraga
2022-09-12 9:52 ` [PATCH wireless-next v2 04/12] brcmfmac: firmware: Support passing in multiple board_types Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-12 9:53 ` [PATCH wireless-next v2 05/12] brcmfmac: pcie: Read Apple OTP information Russell King
2022-09-12 9:53 ` [PATCH wireless-next v2 06/12] brcmfmac: of: Fetch Apple properties Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-12 9:53 ` [PATCH wireless-next v2 07/12] brcmfmac: pcie: Perform firmware selection for Apple platforms Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-12 9:53 ` [PATCH wireless-next v2 08/12] brcmfmac: firmware: Allow platform to override macaddr Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-12 9:53 ` [PATCH wireless-next v2 09/12] brcmfmac: msgbuf: Increase RX ring sizes to 1024 Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-12 9:53 ` [PATCH wireless-next v2 10/12] brcmfmac: pcie: Support PCIe core revisions >= 64 Russell King
2022-09-12 9:53 ` [PATCH wireless-next v2 11/12] brcmfmac: pcie: Add IDs/properties for BCM4378 Russell King
2022-09-15 15:34 ` Alvin Šipraga
2022-09-15 16:54 ` Russell King (Oracle)
2022-09-15 16:59 ` Alvin Šipraga
2022-09-16 7:31 ` Kalle Valo
2022-09-12 9:53 ` [PATCH wireless-next v2 12/12] arm64: dts: apple: Add WiFi module and antenna properties Russell King
2022-09-13 6:52 ` Kalle Valo
2022-09-13 16:30 ` Hector Martin
2022-09-16 7:28 ` Kalle Valo
2022-09-14 10:31 ` [PATCH wireless-next v2 0/12] Add support for bcm4378 on Apple platforms Arend Van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yx9CM210SorcM1nP@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=ALSI@bang-olufsen$(echo .)dk \
--cc=SHA-cyfmac-dev-list@infineon$(echo .)com \
--cc=alyssa@rosenzweig$(echo .)io \
--cc=arend@broadcom$(echo .)com \
--cc=asahi@lists$(echo .)linux.dev \
--cc=aspriel@gmail$(echo .)com \
--cc=brcm80211-dev-list.pdl@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=franky.lin@broadcom$(echo .)com \
--cc=hante.meuleman@broadcom$(echo .)com \
--cc=krzysztof.kozlowski+dt@linaro$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kvalo@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-wireless@vger$(echo .)kernel.org \
--cc=marcan@marcan$(echo .)st \
--cc=mark.kettenis@xs4all$(echo .)nl \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=sven@svenpeter$(echo .)dev \
--cc=zajec5@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox