Subject: Re: [RFC PATCH v2 0/3] Create common DPLL/clock configuration API

From: Jiri Pirko <[email-masked]>
Date: Thu, 29 Sep 2022 13:40:57 +0200

Sun, Jun 26, 2022 at 09:24:41PM CEST, [email-masked] wrote:
>From: Vadim Fedorenko <[email-masked]>
>
>Implement common API for clock/DPLL configuration and status reporting.
>The API utilises netlink interface as transport for commands and event
>notifications. This API aim to extend current pin configuration and
>make it flexible and easy to cover special configurations.

Do you have the userspace part somewhere?
It is very nice to add example outputs of user cmdline of such tool to
the patch description/cover letter.

Also, did you consider usage of sysfs? Why it isn't a better fit than
netlink?

Regarding the naming, is "dpll" the correct one. Forgive me for being a
syncE greenie, but isn't dpll just one algo to achieve syntonous
clocks? Perhaps "dco" as for "Digitally Controlled Oscillator" would be
somewhat better fit?

>
>v1 -> v2:
> * implement returning supported input/output types
> * ptp_ocp: follow suggestions from Jonathan
> * add linux-clk mailing list
>v0 -> v1:
> * fix code style and errors
> * add linux-arm mailing list
>
>
>Vadim Fedorenko (3):
>  dpll: Add DPLL framework base functions
>  dpll: add netlink events
>  ptp_ocp: implement DPLL ops
>
> MAINTAINERS                 |   8 +
> drivers/Kconfig             |   2 +
> drivers/Makefile            |   1 +
> drivers/dpll/Kconfig        |   7 +
> drivers/dpll/Makefile       |   7 +
> drivers/dpll/dpll_core.c    | 161 ++++++++++
> drivers/dpll/dpll_core.h    |  40 +++
> drivers/dpll/dpll_netlink.c | 595 ++++++++++++++++++++++++++++++++++++
> drivers/dpll/dpll_netlink.h |  14 +
> drivers/ptp/Kconfig         |   1 +
> drivers/ptp/ptp_ocp.c       | 169 +++++++---
> include/linux/dpll.h        |  29 ++
> include/uapi/linux/dpll.h   |  81 +++++
> 13 files changed, 1079 insertions(+), 36 deletions(-)
> create mode 100644 drivers/dpll/Kconfig
> create mode 100644 drivers/dpll/Makefile
> create mode 100644 drivers/dpll/dpll_core.c
> create mode 100644 drivers/dpll/dpll_core.h
> create mode 100644 drivers/dpll/dpll_netlink.c
> create mode 100644 drivers/dpll/dpll_netlink.h
> create mode 100644 include/linux/dpll.h
> create mode 100644 include/uapi/linux/dpll.h
>
>-- 
>2.27.0
>