From: Breno Leitao <leitao@debian•org>
To: Kuniyuki Iwashima <kuniyu@amazon•com>
Cc: davem@davemloft•net, dsahern@kernel•org, edumazet@google•com,
horms@kernel•org, kuba@kernel•org, linux-kernel@vger•kernel.org,
netdev@vger•kernel.org, pabeni@redhat•com
Subject: Re: [PATCH net-next 9/9] net: fib_rules: Use nlmsg_payload in fib_valid_dumprule_req
Date: Mon, 14 Apr 2025 05:03:01 -0700 [thread overview]
Message-ID: <Z/z5dTyAdyiBsiit@gmail.com> (raw)
In-Reply-To: <20250411213952.69561-1-kuniyu@amazon.com>
On Fri, Apr 11, 2025 at 02:38:01PM -0700, Kuniyuki Iwashima wrote:
> From: Breno Leitao <leitao@debian•org>
> Date: Fri, 11 Apr 2025 10:00:56 -0700
> > Leverage the new nlmsg_payload() helper to avoid checking for message
> > size and then reading the nlmsg data.
> >
> > Signed-off-by: Breno Leitao <leitao@debian•org>
>
> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon•com>
>
> You can use it for fib_newrule() and fib_delrule() where
> nlmsg_data() is prefetched.
Agree. the code becomes way more readable, and more looks like more
"net" code.
Thanks for the suggestion, I am adding an additional patch for this one.
--breno
prev parent reply other threads:[~2025-04-14 12:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 17:00 [PATCH net-next 0/9] net: Introduce nlmsg_payload helper Breno Leitao
2025-04-11 17:00 ` [PATCH net-next 1/9] netlink: " Breno Leitao
2025-04-11 21:12 ` Kuniyuki Iwashima
2025-04-11 23:01 ` Jakub Kicinski
2025-04-11 17:00 ` [PATCH net-next 2/9] neighbour: Use nlmsg_payload in neightbl_valid_dump_info Breno Leitao
2025-04-11 21:19 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 3/9] neighbour: Use nlmsg_payload in neigh_valid_get_req Breno Leitao
2025-04-11 21:22 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 4/9] rtnetlink: Use nlmsg_payload in valid_fdb_dump_strict Breno Leitao
2025-04-11 21:25 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 5/9] mpls: Use nlmsg_payload in mpls_valid_fib_dump_req Breno Leitao
2025-04-11 21:28 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 6/9] ipv6: Use nlmsg_payload in inet6_valid_dump_ifaddr_req Breno Leitao
2025-04-11 21:29 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 7/9] ipv6: Use nlmsg_payload in inet6_rtm_valid_getaddr_req Breno Leitao
2025-04-11 21:33 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 8/9] mpls: Use nlmsg_payload in mpls_valid_getroute_req Breno Leitao
2025-04-11 21:34 ` Kuniyuki Iwashima
2025-04-11 17:00 ` [PATCH net-next 9/9] net: fib_rules: Use nlmsg_payload in fib_valid_dumprule_req Breno Leitao
2025-04-11 21:38 ` Kuniyuki Iwashima
2025-04-14 12:03 ` Breno Leitao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/z5dTyAdyiBsiit@gmail.com \
--to=leitao@debian$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dsahern@kernel$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuniyu@amazon$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox