Subject: Re: [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops

From: "Dr. David Alan Gilbert" <[email-masked]>
Date: Thu, 26 Dec 2024 14:13:48 +0000

Oops, forgot to cc in [email-masked]:

* [email-masked] ([email-masked]) wrote:
> From: "Dr. David Alan Gilbert" <[email-masked]>
> 
> The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of
> commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)")
> 
> but has remained unused.
> 
> The functions it references are still referenced elsewhere.
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <[email-masked]>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h |  1 -
>  drivers/net/ethernet/intel/ixgbevf/mbx.c     | 12 ------------
>  2 files changed, 13 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> index 130cb868774c..a43cb500274e 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h
> @@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info;
>  extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info;
>  extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info;
>  extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info;
> -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops;
>  
>  /* needed by ethtool.c */
>  extern const char ixgbevf_driver_name[];
> diff --git a/drivers/net/ethernet/intel/ixgbevf/mbx.c b/drivers/net/ethernet/intel/ixgbevf/mbx.c
> index a55dd978f7ca..24d0237e7a99 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/mbx.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/mbx.c
> @@ -505,15 +505,3 @@ const struct ixgbe_mbx_operations ixgbevf_mbx_ops_legacy = {
>  	.check_for_ack	= ixgbevf_check_for_ack_vf,
>  	.check_for_rst	= ixgbevf_check_for_rst_vf,
>  };
> -
> -/* Mailbox operations when running on Hyper-V.
> - * On Hyper-V, PF/VF communication is not through the
> - * hardware mailbox; this communication is through
> - * a software mediated path.
> - * Most mail box operations are noop while running on
> - * Hyper-V.
> - */
> -const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops = {
> -	.init_params	= ixgbevf_init_mbx_params_vf,
> -	.check_for_rst	= ixgbevf_check_for_rst_vf,
> -};
> -- 
> 2.47.1
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/