From: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
kuba@kernel•org, pabeni@redhat•com, andrew+netdev@lunn•ch,
pavan.chebbi@broadcom•com, andrew.gospodarek@broadcom•com,
somnath.kotur@broadcom•com
Subject: Re: [PATCH net-next 01/10] bnxt_en: Set NAPR 1.2 support when registering with firmware
Date: Mon, 13 Jan 2025 08:56:39 +0100 [thread overview]
Message-ID: <Z4THNzvTUecR8QUp@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250113063927.4017173-2-michael.chan@broadcom.com>
On Sun, Jan 12, 2025 at 10:39:18PM -0800, Michael Chan wrote:
> NPAR 1.2 adds a transparent VLAN tag for all packets between the NIC
> and the switch. Because of that, RX VLAN acceleration cannot be
> supported for any additional host configured VLANs. The driver has
> to acknowledge that it can support no RX VLAN acceleration and
> set the NPAR 1.2 supported flag when registering with the FW.
> Otherwise, the FW call will fail and the driver will abort on these
> NPAR 1.2 NICs with this error:
>
> bnxt_en 0000:26:00.0 (unnamed net_device) (uninitialized): hwrm req_type 0x1d seq id 0xb error 0x2
>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom•com>
> Signed-off-by: Michael Chan <michael.chan@broadcom•com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++++
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 884d42db5554..8527788bed91 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -5537,6 +5537,8 @@ int bnxt_hwrm_func_drv_rgtr(struct bnxt *bp, unsigned long *bmap, int bmap_size,
> if (bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY)
> flags |= FUNC_DRV_RGTR_REQ_FLAGS_ERROR_RECOVERY_SUPPORT |
> FUNC_DRV_RGTR_REQ_FLAGS_MASTER_SUPPORT;
> + if (bp->fw_cap & BNXT_FW_CAP_NPAR_1_2)
> + flags |= FUNC_DRV_RGTR_REQ_FLAGS_NPAR_1_2_SUPPORT;
> req->flags = cpu_to_le32(flags);
> req->ver_maj_8b = DRV_VER_MAJ;
> req->ver_min_8b = DRV_VER_MIN;
> @@ -8338,6 +8340,7 @@ static int bnxt_hwrm_func_qcfg(struct bnxt *bp)
>
> switch (resp->port_partition_type) {
> case FUNC_QCFG_RESP_PORT_PARTITION_TYPE_NPAR1_0:
> + case FUNC_QCFG_RESP_PORT_PARTITION_TYPE_NPAR1_2:
> case FUNC_QCFG_RESP_PORT_PARTITION_TYPE_NPAR1_5:
> case FUNC_QCFG_RESP_PORT_PARTITION_TYPE_NPAR2_0:
> bp->port_partition_type = resp->port_partition_type;
> @@ -9502,6 +9505,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp)
> bp->fw_cap |= BNXT_FW_CAP_HOT_RESET_IF;
> if (BNXT_PF(bp) && (flags_ext & FUNC_QCAPS_RESP_FLAGS_EXT_FW_LIVEPATCH_SUPPORTED))
> bp->fw_cap |= BNXT_FW_CAP_LIVEPATCH;
> + if (flags_ext & FUNC_QCAPS_RESP_FLAGS_EXT_NPAR_1_2_SUPPORTED)
> + bp->fw_cap |= BNXT_FW_CAP_NPAR_1_2;
> if (BNXT_PF(bp) && (flags_ext & FUNC_QCAPS_RESP_FLAGS_EXT_DFLT_VLAN_TPID_PCP_SUPPORTED))
> bp->fw_cap |= BNXT_FW_CAP_DFLT_VLAN_TPID_PCP;
> if (flags_ext & FUNC_QCAPS_RESP_FLAGS_EXT_BS_V2_SUPPORTED)
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> index 094c9e95b463..a634ad76177d 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> @@ -2488,6 +2488,7 @@ struct bnxt {
> #define BNXT_FW_CAP_CFA_RFS_RING_TBL_IDX_V3 BIT_ULL(39)
> #define BNXT_FW_CAP_VNIC_RE_FLUSH BIT_ULL(40)
> #define BNXT_FW_CAP_SW_MAX_RESOURCE_LIMITS BIT_ULL(41)
> + #define BNXT_FW_CAP_NPAR_1_2 BIT_ULL(42)
>
> u32 fw_dbg_cap;
>
> --
> 2.30.1
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
next prev parent reply other threads:[~2025-01-13 7:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 6:39 [PATCH net-next 00/10] bnxt_en: Add NPAR 1.2 and TPH support Michael Chan
2025-01-13 6:39 ` [PATCH net-next 01/10] bnxt_en: Set NAPR 1.2 support when registering with firmware Michael Chan
2025-01-13 7:56 ` Michal Swiatkowski [this message]
2025-01-13 6:39 ` [PATCH net-next 02/10] bnxt_en Refactor completion ring allocation logic for P5_PLUS chips Michael Chan
2025-01-13 7:59 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 03/10] bnxt_en: Refactor TX ring allocation logic Michael Chan
2025-01-13 8:02 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 04/10] bnxt_en: Refactor completion ring free routine Michael Chan
2025-01-13 8:06 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 05/10] bnxt_en: Refactor bnxt_free_tx_rings() to free per Tx ring Michael Chan
2025-01-13 8:17 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 06/10] bnxt_en: Refactor RX/RX AGG ring parameters setup for P5_PLUS Michael Chan
2025-01-13 8:27 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 07/10] bnxt_en: Pass NQ ID to the FW when allocating RX/RX AGG rings Michael Chan
2025-01-13 8:29 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 08/10] bnxt_en: Reallocate Rx completion ring for TPH support Michael Chan
2025-01-13 8:35 ` Michal Swiatkowski
2025-01-14 21:42 ` Michael Chan
2025-01-15 5:58 ` Michal Swiatkowski
2025-01-13 6:39 ` [PATCH net-next 09/10] bnxt_en: Extend queue stop/start for Tx rings Michael Chan
2025-01-13 8:40 ` Michal Swiatkowski
2025-01-14 2:05 ` Somnath Kotur
2025-01-15 1:29 ` Michael Chan
2025-01-13 16:01 ` Bjorn Helgaas
2025-01-14 4:57 ` Somnath Kotur
2025-01-14 8:48 ` kernel test robot
2025-01-14 11:23 ` kernel test robot
2025-01-13 6:39 ` [PATCH net-next 10/10] bnxt_en: Add TPH support in BNXT driver Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4THNzvTUecR8QUp@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux$(echo .)intel.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox