public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>
To: Sanman Pradhan <sanman.p211993@gmail•com>
Cc: netdev@vger•kernel.org, alexanderduyck@fb•com, kuba@kernel•org,
	kernel-team@meta•com, andrew+netdev@lunn•ch, davem@davemloft•net,
	edumazet@google•com, pabeni@redhat•com,
	kalesh-anakkur.purayil@broadcom•com, linux@roeck-us•net,
	mohsin.bashr@gmail•com, jdelvare@suse•com, horms@kernel•org,
	suhui@nfschina•com, linux-kernel@vger•kernel.org,
	vadim.fedorenko@linux•dev, linux-hwmon@vger•kernel.org,
	sanmanpradhan@meta•com
Subject: Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading temperature and voltage sensors
Date: Tue, 14 Jan 2025 09:31:43 +0100	[thread overview]
Message-ID: <Z4Yg79d4KoBrNGFG@mev-dev.igk.intel.com> (raw)
In-Reply-To: <20250114000705.2081288-3-sanman.p211993@gmail.com>

On Mon, Jan 13, 2025 at 04:07:04PM -0800, Sanman Pradhan wrote:
> Add support for reading temperature and voltage sensor data from firmware
> by implementing a new TSENE message type and response parsing. This adds
> message handler infrastructure to transmit sensor read requests and parse
> responses. The sensor data will be exposed through the driver's hwmon interface.
> 
> Signed-off-by: Sanman Pradhan <sanman.p211993@gmail•com>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 89 ++++++++++++++++++++-
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.h  | 15 ++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 72 +++++++++++++++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.h |  7 ++
>  4 files changed, 179 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> index 320615a122e4..bbc7c1c0c37e 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> @@ -228,9 +228,9 @@ static void fbnic_mbx_process_tx_msgs(struct fbnic_dev *fbd)
>  	tx_mbx->head = head;
>  }
> 

[...]

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux•intel.com>

> --
> 2.43.5

  parent reply	other threads:[~2025-01-14  8:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-14  0:07 [PATCH net-next 0/3] eth: fbnic: Add hardware monitoring support Sanman Pradhan
2025-01-14  0:07 ` [PATCH net-next 1/3] eth: fbnic: hwmon: Add completion infrastructure for firmware requests Sanman Pradhan
2025-01-14  8:30   ` Michal Swiatkowski
2025-01-14  0:07 ` [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading temperature and voltage sensors Sanman Pradhan
2025-01-14  1:19   ` Andrew Lunn
2025-01-14  4:00     ` Jakub Kicinski
2025-01-14  8:31   ` Michal Swiatkowski [this message]
2025-01-14  0:07 ` [PATCH net-next 3/3] eth: fbnic: Add hardware monitoring support via HWMON interface Sanman Pradhan
2025-01-14  8:35   ` Michal Swiatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4Yg79d4KoBrNGFG@mev-dev.igk.intel.com \
    --to=michal.swiatkowski@linux$(echo .)intel.com \
    --cc=alexanderduyck@fb$(echo .)com \
    --cc=andrew+netdev@lunn$(echo .)ch \
    --cc=davem@davemloft$(echo .)net \
    --cc=edumazet@google$(echo .)com \
    --cc=horms@kernel$(echo .)org \
    --cc=jdelvare@suse$(echo .)com \
    --cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
    --cc=kernel-team@meta$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=linux-hwmon@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux@roeck-us$(echo .)net \
    --cc=mohsin.bashr@gmail$(echo .)com \
    --cc=netdev@vger$(echo .)kernel.org \
    --cc=pabeni@redhat$(echo .)com \
    --cc=sanman.p211993@gmail$(echo .)com \
    --cc=sanmanpradhan@meta$(echo .)com \
    --cc=suhui@nfschina$(echo .)com \
    --cc=vadim.fedorenko@linux$(echo .)dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox