From: Joe Damato <jdamato@fastly•com>
To: Ahmed Zaki <ahmed.zaki@intel•com>
Cc: netdev@vger•kernel.org, intel-wired-lan@lists•osuosl.org,
andrew+netdev@lunn•ch, edumazet@google•com, kuba@kernel•org,
horms@kernel•org, pabeni@redhat•com, davem@davemloft•net,
michael.chan@broadcom•com, tariqt@nvidia•com,
anthony.l.nguyen@intel•com, przemyslaw.kitszel@intel•com,
shayd@nvidia•com, akpm@linux-foundation•org, shayagr@amazon•com,
kalesh-anakkur.purayil@broadcom•com
Subject: Re: [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config
Date: Thu, 23 Jan 2025 12:27:00 -0800 [thread overview]
Message-ID: <Z5KmFNz7HDm9itoC@LQ3V64L9R2> (raw)
In-Reply-To: <20250118003335.155379-1-ahmed.zaki@intel.com>
On Fri, Jan 17, 2025 at 05:33:30PM -0700, Ahmed Zaki wrote:
> Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
> after reset. However, since there can be only one IRQ affinity notifier
> for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
> management in the core (which also registers separate IRQ affinity
> notifiers).
>
> Move the IRQ affinity management to the napi struct. This way we can have
> a unified IRQ notifier to re-apply the user-set affinity and also manage
> the ARFS rmaps. Patches 1 and 2 move the ARFS rmap management to CORE.
> Patch 3 adds the IRQ affinity mask to napi_config and re-applies the mask
> after reset. Patches 4-6 use the new API for bnxt, ice and idpf drivers.
Thanks for your work on this; I like the direction this is going and
I think providing this functionality via the core is very cool.
I am hoping that once this is merged, a change can be made that
builds on this work to eliminate the duplicated
if (!cpumask_test_cpu(cpu, affinity_mask))
that a few drivers have in their napi poll functions with something
more generic for drivers which have persistent NAPI configs.
prev parent reply other threads:[~2025-01-23 20:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-18 0:33 [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 1/5] net: move ARFS rmap management to core Ahmed Zaki
2025-01-21 0:59 ` Jakub Kicinski
2025-01-21 14:52 ` Ahmed Zaki
2025-01-23 19:28 ` Joe Damato
2025-01-23 20:13 ` Ahmed Zaki
2025-01-23 20:20 ` Joe Damato
2025-01-18 0:33 ` [PATCH net-next v6 2/5] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-01-21 1:03 ` Jakub Kicinski
2025-01-23 20:18 ` Joe Damato
2025-02-03 21:32 ` Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 3/5] bnxt: use napi's irq affinity Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 4/5] ice: " Ahmed Zaki
2025-01-18 0:33 ` [PATCH net-next v6 5/5] idpf: " Ahmed Zaki
2025-01-21 1:03 ` [PATCH net-next v6 0/5] net: napi: add CPU affinity to napi->config Jakub Kicinski
2025-01-21 14:54 ` Ahmed Zaki
2025-01-23 20:27 ` Joe Damato [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5KmFNz7HDm9itoC@LQ3V64L9R2 \
--to=jdamato@fastly$(echo .)com \
--cc=ahmed.zaki@intel$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=shayagr@amazon$(echo .)com \
--cc=shayd@nvidia$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox